rukpak icon indicating copy to clipboard operation
rukpak copied to clipboard

BundleDeployment: add and implement required serviceAccountName and installNamespace fields

Open joelanford opened this issue 1 year ago • 2 comments

Hacking a bit on rukpak BundleDeployment to put the following new required fields in the spec:

  • installNamespace
  • serviceAccountName

In the reconciler, I've removed all cluster-admin-like permissions and replaced them with just permission to create token requests.

I've also reorganized helm-operator-plugins a bit:

Lastly, I've added a token getter/cache implementation and updated the setup of the controllers in rukpak's main.go files to use that for the actionConfigGetter configuration.

With all of that, I've run a few tests with permissions missing and with all permissions present, and things seem to work.

This is a WIP because nothing in helm-operator-plugins is merged, and I've pinned to my local copy that combines both of the above PRs.

joelanford avatar Apr 10 '24 20:04 joelanford

Codecov Report

Attention: Patch coverage is 0% with 7 lines in your changes are missing coverage. Please review.

Project coverage is 35.89%. Comparing base (3d1ba69) to head (121035b). Report is 34 commits behind head on main.

Files Patch % Lines
...l/controllers/bundledeployment/bundledeployment.go 0.00% 7 Missing :warning:
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #857      +/-   ##
==========================================
- Coverage   37.28%   35.89%   -1.39%     
==========================================
  Files           9        8       -1     
  Lines         853      808      -45     
==========================================
- Hits          318      290      -28     
+ Misses        491      478      -13     
+ Partials       44       40       -4     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Apr 10 '24 21:04 codecov[bot]

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-merge-robot avatar May 02 '24 00:05 openshift-merge-robot

This PR has become stale because it has been open for 30 days with no activity. Please update this PR or remove the lifecycle/stale label before it is automatically closed in 30 days. Adding the lifecycle/frozen label will cause this PR to ignore lifecycle events.

github-actions[bot] avatar Jun 02 '24 00:06 github-actions[bot]

This PR has been closed as no updates were detected after 30 days of being stale. Please feel free to reopen this PR if necessary.

github-actions[bot] avatar Jul 04 '24 00:07 github-actions[bot]