operator-sdk icon indicating copy to clipboard operation
operator-sdk copied to clipboard

Generate bundle ignore RelatedImages from config/manifests/bases

Open rollandf opened this issue 2 years ago • 10 comments

Bug Report

What did you do?

generate bundle using kustomize with RelatedImages in config/manifests/bases/my.clusterserviceversion.yaml

What did you expect to see?

The generated CSV should include the provided RelatedImages

What did you see instead? Under which circumstances?

The generated CSV does not include the provided RelatedImages used to worked until v1.19.0

Environment

Operator type:

/language go

Kubernetes cluster type: vanilla

$ operator-sdk version v1.19.1 (worked with v1.19.0)

$ go version (if language is Go)

$ kubectl version

Possible Solution

Merge the provided RelatedImages with the auto detected. Suspected PR that introduced the change: #5656

Additional context

rollandf avatar Oct 03 '23 12:10 rollandf

Hi @rollandf, does this issues exist with a recent version of operator-sdk? v1.19.1 is well over a year and a half old, just trying to gauge if this issue still exists. Thanks.

acornett21 avatar Oct 09 '23 15:10 acornett21

Hi, yes it still exists in latest version.

Example of base yaml: https://github.com/Mellanox/network-operator/blob/master/config/manifests/bases/nvidia-network-operator.clusterserviceversion.yaml#L78

rollandf avatar Oct 09 '23 16:10 rollandf

Thanks for confirming...As a workaround, operator-sdk can build the related images section in the csv with the following:

USE_IMAGE_DIGESTS=true make bundle

This pins the images to the proper sha value and also builds the related images section.

acornett21 avatar Oct 09 '23 17:10 acornett21

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale. Stale issues rot after an additional 30d of inactivity and eventually close. Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

openshift-bot avatar Jan 08 '24 01:01 openshift-bot

/remove-lifecycle stale

rollandf avatar Jan 17 '24 12:01 rollandf

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale. Stale issues rot after an additional 30d of inactivity and eventually close. Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

openshift-bot avatar Apr 17 '24 01:04 openshift-bot

/remove-lifecycle stale

rollandf avatar Apr 17 '24 06:04 rollandf

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale. Stale issues rot after an additional 30d of inactivity and eventually close. Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

openshift-bot avatar Jul 16 '24 09:07 openshift-bot

/remove-lifecycle stale

rollandf avatar Jul 16 '24 09:07 rollandf