wip: work on bumping KB

[varshaprasad96]

trafficstars

Things to do:

• [x] Update ansible operator code based on https://github.com/kubernetes-sigs/controller-runtime/pull/2427
• [x] Generate testdata
• [x] Update documentation
• [x] Add changelog/migration guide

Description of the change:

Motivation for the change:

Checklist

If the pull request includes user-facing changes, extra documentation is required:

• [ ] Add a new changelog fragment in changelog/fragments (see changelog/fragments/00-template.yaml)
• [ ] Add or update relevant sections of the docs website in website/content/en/docs

closes: https://github.com/operator-framework/operator-sdk/issues/6571

[varshaprasad96]

/hold Please hold from reviewing. A bunch of changes need to be done, work in progress.

[varshaprasad96]

Blocked by https://github.com/kubernetes-sigs/controller-runtime/pull/2427

[varshaprasad96]

Things left todo:

1. Fix error checking during OLM install command. The API groups should unwrap and verify the Discovery error passed down by controller-runtime.
2. Verify linter, and make sure it passes.
3. Verify documentation is upto date.

I haven't been able to prioritize this PR immediately, should have it moving sometime next week.

[varshaprasad96]

@Neo2308 @bshephar I've been distracted with other priorities, and could not get the time to finish this. Would any one of you like to take this over and push it to the finish line? The work is almost done, just need to debug the two scorecard tests, which is causing e2e tests to fail. If you are comfortable, please let me know. I'll add you as a collaborator in this PR. Thank you!

[Neo2308]

@varshaprasad96 raised a PR to this branch with the fix for scorecard. (Tested for go e2e)

[varshaprasad96]

@Neo2308 I have merged your pull request.

• To fix the sanity: Can you bump the local operator-sdk version which you have to the latest (1.31) and run make generate. That should fix the diffs.
• To fix unit tests: The new handler package in ansible is using envtest binaries. The KUBEBUILDER_ASSETS var should be set to point to the right location where binaries are downloaded using setup-envtest. Similar to how it is done here: https://github.com/operator-framework/operator-sdk/blob/e67da35ef4fff3e471a208904b2a142b27ae32b1/Makefile#L169. Either we can set this up before calling the unit test target, or remove the handler tests package from in here and have it tested separately.

Thanks for working on this! Feel free to lmk if you have any questions.

[Neo2308]

@varshaprasad96 raised a PR to this branch with the fix for unit & sanity tests.

Need help on fixing the e2e tests.

[varshaprasad96]

@Neo2308 Thanks for the fix. Looking into the CI, it seems like the e2e tests are failing on the run packagemanifests tests for OLM. Before we start looking into it and figure out the issue, I'm wondering if it is even required. Packagemanifests have been deprecated for long, are not being used widely, since folks have moved to using operator bundles. So it should be fine to remove them. I've created a slack thread to confirm with other maintainers: https://kubernetes.slack.com/archives/C017UU45SHL/p1694445066414709

[openshift-merge-robot]

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[Neo2308]

@varshaprasad96 did we hear back on the slack thread? I dont have access to this slack organisation.

[varshaprasad96]

@Neo2308 I have not received any reply on this. But to unblock for now, I'd say to proceed with removing tests for package manifests but ensure that run bundle works as expected. Those can be added back in, if there is any strong opinion against removing them during reviews.

[Neo2308]

@varshaprasad96 could you take this up since I am not sure what exactly needs to be removed?

[everettraven]

/assign @oceanc80

[Neo2308]

@varshaprasad96 / @oceanc80 What are the next steps here? Is there something I can help with? Considering that k8s 1.29 is scheduled to be released this week, we would be 3 versions behind the master.

[Neo2308]

@varshaprasad96 could we close this PR since its been covered in https://github.com/operator-framework/operator-sdk/pull/6613 and available in https://github.com/operator-framework/operator-sdk/releases/tag/v1.33.0

[openshift-bot]

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale. Stale issues rot after an additional 30d of inactivity and eventually close. Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

[openshift-bot]

Stale issues rot after 30d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle rotten. Rotten issues close after an additional 30d of inactivity. Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle rotten /remove-lifecycle stale

[openshift-bot]

Rotten issues close after 30d of inactivity.

Reopen the issue by commenting /reopen. Mark the issue as fresh by commenting /remove-lifecycle rotten. Exclude this issue from closing again by commenting /lifecycle frozen.

/close

[openshift-ci[bot]]

@openshift-bot: Closed this PR.

In response to this:

Rotten issues close after 30d of inactivity.

Reopen the issue by commenting /reopen. Mark the issue as fresh by commenting /remove-lifecycle rotten. Exclude this issue from closing again by commenting /lifecycle frozen.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.