operator-sdk icon indicating copy to clipboard operation
operator-sdk copied to clipboard

Set REST timeout when timeout cli arg is provided

Open sebsoto opened this issue 2 years ago • 6 comments

Description of the change: The timeout arg sets the overall timeout for the full command to finish, such as run bundle, but it doesn't affect the timeout of individual API server requests. This remains the default timeout specified in the API server configuration. This means that even if a user wants run bundle to timeout after 5m, the command may return earlier due to an individual request's timeout being hit.

This commit fixes that behavior by setting the Timeout value in the client cfg to the value passed in by the user, this will prevent the individual request from timing out before the desired timeout.

Motivation for the change: operator-sdk bundle run fails on operators that take longer than usual to install

sebsoto avatar May 19 '23 14:05 sebsoto

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale. Stale issues rot after an additional 30d of inactivity and eventually close. Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

openshift-bot avatar Aug 21 '23 01:08 openshift-bot

/remove-lifecycle stale

sebsoto avatar Sep 06 '23 19:09 sebsoto

@everettraven Could you take another a look at this when you get a chance? Thanks!

sebsoto avatar Sep 20 '23 13:09 sebsoto

Looks like the actions here are stuck. Going to close and re-open to kick them

everettraven avatar Oct 20 '23 13:10 everettraven

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale. Stale issues rot after an additional 30d of inactivity and eventually close. Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

openshift-bot avatar Jan 19 '24 01:01 openshift-bot

Stale issues rot after 30d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle rotten. Rotten issues close after an additional 30d of inactivity. Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle rotten /remove-lifecycle stale

openshift-bot avatar Feb 18 '24 08:02 openshift-bot

Rotten issues close after 30d of inactivity.

Reopen the issue by commenting /reopen. Mark the issue as fresh by commenting /remove-lifecycle rotten. Exclude this issue from closing again by commenting /lifecycle frozen.

/close

openshift-bot avatar Mar 20 '24 00:03 openshift-bot

@openshift-bot: Closed this PR.

In response to this:

Rotten issues close after 30d of inactivity.

Reopen the issue by commenting /reopen. Mark the issue as fresh by commenting /remove-lifecycle rotten. Exclude this issue from closing again by commenting /lifecycle frozen.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci[bot] avatar Mar 20 '24 00:03 openshift-ci[bot]