operator-sdk icon indicating copy to clipboard operation
operator-sdk copied to clipboard

Update docs about resources watched by the Controller

Open dacamposol opened this issue 3 years ago • 3 comments

Description of the change: Adds explanation and example about how to correctly use Owns in the Controller to watch a secondary dependent resource.

Motivation for the change: https://github.com/operator-framework/operator-sdk/issues/5949

Checklist If the pull request includes user-facing changes, extra documentation is required:

dacamposol avatar Jul 19 '22 16:07 dacamposol

@camilamacedo86 I think you need to remove the tag do-not-merge/hold in order to be able to merge this.

dacamposol avatar Jul 22 '22 14:07 dacamposol

/hold cancel

Let's see what the others think about

camilamacedo86 avatar Jul 22 '22 17:07 camilamacedo86

@rashmigottipati could you please check if this could be merged?

dacamposol avatar Jul 25 '22 11:07 dacamposol

Hi @dacamposol ! Thanks for the contribution!

I think this is a valuable addition to the tutorial, I just have a couple minor nits that I think need to be addressed before it can be merged.

I have consumed your PR comments.

Please check :)

dacamposol avatar Oct 06 '22 11:10 dacamposol

@dacamposol also if you could sign your commits that would fix the DCO error. git rebase HEAD~3 --signoff or however many commits were not signed.

jmrodri avatar Oct 21 '22 19:10 jmrodri

@dacamposol also if you could sign your commits that would fix the DCO error. git rebase HEAD~3 --signoff or however many commits were not signed.

You cannot rebase a merge commit.

The DCO bot is incorrectly configured, otherwise nobody can interact with the branch directly from the web interface (like accepting proposals) or to merge main in the current branch when it's outdated.

Edit: It seems the problem was the co-authored one (again, why needs to be signed a Verified commit?) but the DCO passed after signing that one and leaving the merge by itself.

dacamposol avatar Oct 27 '22 06:10 dacamposol

@everettraven can this be merged, or?

dacamposol avatar Nov 09 '22 16:11 dacamposol

@everettraven can this be merged, or?

@dacamposol Yep, apologies for the delay!

everettraven avatar Nov 09 '22 16:11 everettraven