operator-sdk
operator-sdk copied to clipboard
Update docs about resources watched by the Controller
Description of the change: Adds explanation and example about how to correctly use Owns in the Controller to watch a secondary dependent resource.
Motivation for the change: https://github.com/operator-framework/operator-sdk/issues/5949
Checklist If the pull request includes user-facing changes, extra documentation is required:
- [ ] Add a new changelog fragment in
changelog/fragments(seechangelog/fragments/00-template.yaml) - [x] Add or update relevant sections of the docs website in
website/content/en/docs
@camilamacedo86 I think you need to remove the tag do-not-merge/hold in order to be able to merge this.
/hold cancel
Let's see what the others think about
@rashmigottipati could you please check if this could be merged?
Hi @dacamposol ! Thanks for the contribution!
I think this is a valuable addition to the tutorial, I just have a couple minor nits that I think need to be addressed before it can be merged.
I have consumed your PR comments.
Please check :)
@dacamposol also if you could sign your commits that would fix the DCO error. git rebase HEAD~3 --signoff or however many commits were not signed.
@dacamposol also if you could sign your commits that would fix the DCO error.
git rebase HEAD~3 --signoffor however many commits were not signed.
You cannot rebase a merge commit.
The DCO bot is incorrectly configured, otherwise nobody can interact with the branch directly from the web interface (like accepting proposals) or to merge main in the current branch when it's outdated.
Edit: It seems the problem was the co-authored one (again, why needs to be signed a Verified commit?) but the DCO passed after signing that one and leaving the merge by itself.
@everettraven can this be merged, or?
@everettraven can this be merged, or?
@dacamposol Yep, apologies for the delay!