operator-sdk icon indicating copy to clipboard operation
operator-sdk copied to clipboard

registry_pod: Avoid grace period delay

Open avisiedo opened this issue 3 years ago • 7 comments

Description of the change:

Substitute shell by the last command that serve the registry pod.

Motivation for the change:

The shell script does not propagate the SIGTERM signal that is sent to the pod when it is terminated; to avoid this, we run the last command to substitute the shell process, so that the pod stop immediately instead of waiting the 30 default seconds of the grace period when an user uninstall the operator by using 'operator-sdk cleanup ...' command.

Checklist

If the pull request includes user-facing changes, extra documentation is required:

issue: https://github.com/operator-framework/operator-sdk/issues/5866

avisiedo avatar May 31 '22 07:05 avisiedo

@avisiedo is there a github issue that explains the problem you were having?

jmrodri avatar Jun 03 '22 02:06 jmrodri

@jmrodri No, there is not. What am I missing to propose a change into the repository?

  • I don't see the change as a user-facing change, as the operations and interactions are the same, just improve the time the registry_pod to terminate. Should documentation about this to be provided for the changeling anyway?
  • The same for 'website/content/en/docs', as I don't see changes into the user interaction with this change.

Please correct me on the above if I were wrong in something, and if an issue is required, let me know and I will create it, and I will update this PR to reference the issue.

Thanks

avisiedo avatar Jun 05 '22 09:06 avisiedo

/retest

avisiedo avatar Jun 06 '22 12:06 avisiedo

@avisiedo: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci[bot] avatar Jun 06 '22 12:06 openshift-ci[bot]

@jmrodri In the pipeline I get here and issue related with an external link.

I have checked the link manually and it worked, probably network transitory situations; I can not relaunch the test to check it. :sweat_smile:

If further changes are necessary, or an issue ticket is necessary for the change, please let me know and I will do it

Cheers! :slightly_smiling_face:

avisiedo avatar Jun 13 '22 04:06 avisiedo

I have added an issue at: https://github.com/operator-framework/operator-sdk/issues/5866

avisiedo avatar Jun 13 '22 04:06 avisiedo

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale. Stale issues rot after an additional 30d of inactivity and eventually close. Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

openshift-bot avatar Sep 12 '22 09:09 openshift-bot

Stale issues rot after 30d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle rotten. Rotten issues close after an additional 30d of inactivity. Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle rotten /remove-lifecycle stale

openshift-bot avatar Oct 13 '22 00:10 openshift-bot

Rotten issues close after 30d of inactivity.

Reopen the issue by commenting /reopen. Mark the issue as fresh by commenting /remove-lifecycle rotten. Exclude this issue from closing again by commenting /lifecycle frozen.

/close

openshift-bot avatar Nov 12 '22 08:11 openshift-bot

Rotten issues close after 30d of inactivity.

Reopen the issue by commenting /reopen. Mark the issue as fresh by commenting /remove-lifecycle rotten. Exclude this issue from closing again by commenting /lifecycle frozen.

/close

openshift-bot avatar Nov 12 '22 08:11 openshift-bot

@openshift-bot: Closed this PR.

In response to this:

Rotten issues close after 30d of inactivity.

Reopen the issue by commenting /reopen. Mark the issue as fresh by commenting /remove-lifecycle rotten. Exclude this issue from closing again by commenting /lifecycle frozen.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci[bot] avatar Nov 12 '22 08:11 openshift-ci[bot]