operator-sdk icon indicating copy to clipboard operation
operator-sdk copied to clipboard

Unpin `cryptography ` Python dep for Ansible Operators

Open asmacdo opened this issue 2 years ago • 9 comments

We've got this version pinned https://github.com/operator-framework/operator-sdk/blob/master/images/ansible-operator/Pipfile#L13-L16

It looks like the rust toolkit is available for UBI 8 now, so I think we can start bumping this dep.

Might affect https://github.com/operator-framework/operator-sdk/issues/5619

asmacdo avatar May 09 '22 18:05 asmacdo

This should be pretty easy if anyone wants to pick it up, I'd be willing to coach.

asmacdo avatar Jun 29 '22 18:06 asmacdo

/assign

rudradevpal avatar Jul 05 '22 03:07 rudradevpal

Hi @rudradevpal thank you for picking this up!

For this one, you can start by updating the pipfile and then using pipenv to update the .lock file. (Let me know if you need some docs links to figure that out.)

From there, you can use make image-build ansible-operator to build the image.

https://github.com/operator-framework/operator-sdk/blob/9762aa24be11521165ebf7568b674146c6a7da32/Makefile#L84

Try out the new image with any ansible-based operator (Memcached tutorial is fine) to make sure it all works.

Repeat for Ansible 2.11 preview image.

Let me know if you could use any assistance!

asmacdo avatar Jul 05 '22 11:07 asmacdo

@asmacdo can you please share docs for

  1. pipenv to update the .lock file
  2. for building and testing

do i just remove the cryptography"==3.3.2" or just change to ~=3.3.2

rudradevpal avatar Jul 05 '22 12:07 rudradevpal

@asmacdo Can you please help on this issue. Waiting for your reply

rudradevpal avatar Jul 07 '22 14:07 rudradevpal

Let's unpin for now.

Use pipenv to install dependencies (from the pipfile) into a temp virtualenv, and it should update the lock file. https://pipenv.pypa.io/en/latest/

asmacdo avatar Jul 07 '22 15:07 asmacdo

So i am just going with putting cryptography= "*" as of now. Also it will help if you can provide doc to test operator-sdk @asmacdo

rudradevpal avatar Jul 07 '22 15:07 rudradevpal

For building and testing, take a look at the makefile. make image-build ansible-operator (also ansible-operator-2.11-preview) will build the images.

Once the images are building, you should be ok to push a PR and let CI run.

asmacdo avatar Jul 07 '22 15:07 asmacdo

Okay thanks @asmacdo

rudradevpal avatar Jul 07 '22 15:07 rudradevpal

@rudradevpal Would you like still pick up this issue. If not feel free to unassigned yourself.

varshaprasad96 avatar Jan 04 '23 19:01 varshaprasad96