operator-sdk icon indicating copy to clipboard operation
operator-sdk copied to clipboard

Allows the `v` char in the version string

Open cardil opened this issue 4 years ago • 8 comments
trafficstars

Description of the change:

Fixes #5342

Checklist

If the pull request includes user-facing changes, extra documentation is required:

cardil avatar Nov 06 '21 11:11 cardil

@cardil thanks for the PR! Once the changelog fragment is added, we should be good to merge this :)

asmacdo avatar Nov 08 '21 19:11 asmacdo

Before we merge this, I just wanted to double check a few things.

  1. Are we talking about the version derived from csv.spec.version?
  2. If so, are we sure OLM supports versions that include a v prefix?

/hold

(feel free to unhold if the above questions are sufficiently answered)

joelanford avatar Nov 10 '21 18:11 joelanford

/cc @jmrodri get an answer to Joe's comment above

jmrodri avatar Jan 14 '22 20:01 jmrodri

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale. Stale issues rot after an additional 30d of inactivity and eventually close. Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

openshift-bot avatar Apr 14 '22 23:04 openshift-bot

/remove-lifecycle stale

cardil avatar Apr 26 '22 10:04 cardil

New changes are detected. LGTM label has been removed.

openshift-ci[bot] avatar Apr 26 '22 10:04 openshift-ci[bot]

At @joelanford:

With the latest changes to this PR, I'm removing the v prefix if there is any. This means any other behavior of operator-sdk is unchanged.

cardil avatar Apr 26 '22 12:04 cardil

Ping!

cardil avatar Aug 25 '22 12:08 cardil

Can I get re-review?

cardil avatar Oct 10 '22 20:10 cardil

/approve /lgtm /ok-to-test The change looks good to me. @joelanford any objections in merging this?

varshaprasad96 avatar Jan 04 '23 18:01 varshaprasad96

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale. Stale issues rot after an additional 30d of inactivity and eventually close. Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

openshift-bot avatar Apr 05 '23 01:04 openshift-bot

Stale issues rot after 30d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle rotten. Rotten issues close after an additional 30d of inactivity. Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle rotten /remove-lifecycle stale

openshift-bot avatar May 05 '23 08:05 openshift-bot

Rotten issues close after 30d of inactivity.

Reopen the issue by commenting /reopen. Mark the issue as fresh by commenting /remove-lifecycle rotten. Exclude this issue from closing again by commenting /lifecycle frozen.

/close

openshift-bot avatar Jun 05 '23 00:06 openshift-bot

@openshift-bot: Closed this PR.

In response to this:

Rotten issues close after 30d of inactivity.

Reopen the issue by commenting /reopen. Mark the issue as fresh by commenting /remove-lifecycle rotten. Exclude this issue from closing again by commenting /lifecycle frozen.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci[bot] avatar Jun 05 '23 00:06 openshift-ci[bot]