operator-sdk icon indicating copy to clipboard operation
operator-sdk copied to clipboard

pkgman-to-bundles does not propagate channels from channel heads

Open joelanford opened this issue 2 years ago • 5 comments

Bug Report

What did you do?

git clone https://github.com/k8s-operatorhub/community-operators
cd community-operators/operators
operator-sdk pkgman-to-bundle etcd etcd-bundles
cat etcd-bundles/bundle-0.9.0/bundle/metadata/annotations.yaml

What did you expect to see?

I expected the command to automatically traverse the replaces chain from each channel head to set the correct channels for all bundles. For example, I expected 0.9.0 to be in channels:

  • clusterwide-alpha due to being in replaces chain of 0.9.4-clusterwide
  • singlenamespace-alpha due to being in the replaces chain of 0.9.4

Also side note (this does not happen for this operator): I would NOT expect bundles to be added to the default channel as a default unless they're actually in the replaces chain for that channel. Put another way, I would expect bundles to only be added to channels based on traversing replaces values from channel heads.

What did you see instead? Under which circumstances?

In the operator-sdk pkgman-to-bundle etcd etcd-bundles output, I see:

INFO[0000] Supported channels cannot be identified from CSV etcdoperator.v0.9.0, using default channel singlenamespace-alpha 

In the 0.9.0/metadata/annotations.yaml file, I see:

  operators.operatorframework.io.bundle.channels.v1: singlenamespace-alpha

Environment

Operator type:

N/A

Kubernetes cluster type:

N/A

$ operator-sdk version

operator-sdk version: "v1.11.0-4-g47d8d671", commit: "47d8d6714e75d858297f42088ce2ec32bd809e00", kubernetes version: "v1.21", go version: "go1.16.7", GOOS: "darwin", GOARCH: "arm64"

$ go version (if language is Go)

go version go1.16.7 darwin/arm64

$ kubectl version

Client Version: version.Info{Major:"1", Minor:"21", GitVersion:"v1.21.1", GitCommit:"5e58841cce77d4bc13713ad2b91fa0d961e69192", GitTreeState:"clean", BuildDate:"2021-05-12T14:18:45Z", GoVersion:"go1.16.4", Compiler:"gc", Platform:"darwin/arm64"}
Server Version: version.Info{Major:"1", Minor:"21", GitVersion:"v1.21.0", GitCommit:"cb303e613a121a29364f75cc67d3d580833a7479", GitTreeState:"clean", BuildDate:"2021-04-08T16:25:06Z", GoVersion:"go1.16.1", Compiler:"gc", Platform:"linux/amd64"}

joelanford avatar Aug 25 '21 01:08 joelanford

@rashmigottipati would we be able to get this in v1.16.0 milestone? If not we can bump it to the next one.

varshaprasad96 avatar Dec 01 '21 19:12 varshaprasad96

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale. Stale issues rot after an additional 30d of inactivity and eventually close. Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

openshift-bot avatar May 04 '22 00:05 openshift-bot

@joelanford Is this still a priority?

asmacdo avatar May 23 '22 18:05 asmacdo

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale. Stale issues rot after an additional 30d of inactivity and eventually close. Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

openshift-bot avatar Aug 22 '22 01:08 openshift-bot

Stale issues rot after 30d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle rotten. Rotten issues close after an additional 30d of inactivity. Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle rotten /remove-lifecycle stale

openshift-bot avatar Sep 21 '22 08:09 openshift-bot

Rotten issues close after 30d of inactivity.

Reopen the issue by commenting /reopen. Mark the issue as fresh by commenting /remove-lifecycle rotten. Exclude this issue from closing again by commenting /lifecycle frozen.

/close

openshift-bot avatar Oct 22 '22 00:10 openshift-bot

@openshift-bot: Closing this issue.

In response to this:

Rotten issues close after 30d of inactivity.

Reopen the issue by commenting /reopen. Mark the issue as fresh by commenting /remove-lifecycle rotten. Exclude this issue from closing again by commenting /lifecycle frozen.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci[bot] avatar Oct 22 '22 00:10 openshift-ci[bot]