operator-registry icon indicating copy to clipboard operation
operator-registry copied to clipboard

(opm render): refine error message to indicate expected input

Open anik120 opened this issue 3 years ago • 3 comments

Description of the change:

Motivation for the change:

Reviewer Checklist

  • [ ] Implementation matches the proposed design, or proposal is updated to match implementation
  • [ ] Sufficient unit test coverage
  • [ ] Sufficient end-to-end test coverage
  • [ ] Docs updated or added to /docs
  • [ ] Commit messages sensible and descriptive

anik120 avatar Mar 22 '22 17:03 anik120

@anik120 Does it make sense to be slightly more generic with this error message though? The labels drive this today, but do we not have code to look at an image and try to find the fbc, database, or manifest directory of a registry+v1 bundle image? And if not, does it make sense for the error message to make room for that improvement in the future?

kevinrizza avatar Mar 22 '22 17:03 kevinrizza

Codecov Report

Merging #939 (13372cc) into master (9999f79) will not change coverage. The diff coverage is 0.00%.

@@           Coverage Diff           @@
##           master     #939   +/-   ##
=======================================
  Coverage   52.21%   52.21%           
=======================================
  Files         103      103           
  Lines        9117     9117           
=======================================
  Hits         4760     4760           
  Misses       3451     3451           
  Partials      906      906           
Impacted Files Coverage Δ
alpha/action/render.go 64.14% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 9999f79...13372cc. Read the comment docs.

codecov[bot] avatar Mar 22 '22 18:03 codecov[bot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: anik120, jackdsite To complete the pull request process, please assign joelanford after the PR has been reviewed. You can assign the PR to them by writing /assign @joelanford in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

openshift-ci[bot] avatar Apr 20 '22 18:04 openshift-ci[bot]

closing PR as stale. Please re-open if it's still important.

perdasilva avatar Feb 19 '24 13:02 perdasilva