take image domain name from env in e2e test
Signed-off-by: akihikokuroda [email protected]
Description of the change:
e2e tests take IMAGE_DOMAIN env variable for the domain name of the image. The default is olmtest. It allows to use the docker.io as the registry for the e2e tests like
KUBECONFIG="$HOME/.kube/config" DOCKER_REGISTRY_HOST=docker.io IMAGE_DOMAIN="your docker id" make build e2e
Motivation for the change: Closes #764 Reviewer Checklist
- [ ] Implementation matches the proposed design, or proposal is updated to match implementation
- [ ] Sufficient unit test coverage
- [ ] Sufficient end-to-end test coverage
- [ ] Docs updated or added to
/docs - [ ] Commit messages sensible and descriptive
Hi @akihikokuroda. Thanks for your PR.
I'm waiting for a operator-framework member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.
Once the patch is verified, the new status will be reflected by the ok-to-test label.
I understand the commands that are listed here.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: akihikokuroda
To complete the pull request process, please assign njhale after the PR has been reviewed.
You can assign the PR to them by writing /assign @njhale in a comment when ready.
The full list of commands accepted by this bot can be found here.
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
Thanks for review. I made suggested changes.
Codecov Report
Merging #791 (910abb0) into master (c426f78) will not change coverage. The diff coverage is
n/a.
:exclamation: Current head 910abb0 differs from pull request most recent head 9ae615d. Consider uploading reports for the commit 9ae615d to get more accurate results
@@ Coverage Diff @@
## master #791 +/- ##
=======================================
Coverage 51.04% 51.04%
=======================================
Files 103 103
Lines 9050 9050
=======================================
Hits 4620 4620
Misses 3553 3553
Partials 877 877
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact),ø = not affected,? = missing dataPowered by Codecov. Last update c426f78...9ae615d. Read the comment docs.
/ok-to-test
@joelanford @grokspawn if you guys can review this that'd be great
/approve
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: akihikokuroda, anik120, grokspawn
The full list of commands accepted by this bot can be found here.
The pull request process is described here
- ~~OWNERS~~ [grokspawn]
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment