operator-registry icon indicating copy to clipboard operation
operator-registry copied to clipboard

Bump grpc-health and return status immediately

Open ecordell opened this issue 4 years ago • 3 comments

Description of the change: updates to the newer health check api that has a watch endpoint.

Motivation for the change: keeping up with grpc, but also hopeful that the watch might improve successful connection times (haven't tested yet)

Reviewer Checklist

  • [ ] Implementation matches the proposed design, or proposal is updated to match implementation
  • [ ] Sufficient unit test coverage
  • [ ] Sufficient end-to-end test coverage
  • [ ] Docs updated or added to /docs
  • [ ] Commit messages sensible and descriptive

ecordell avatar Aug 17 '21 19:08 ecordell

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ecordell

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

openshift-ci[bot] avatar Aug 17 '21 19:08 openshift-ci[bot]

Codecov Report

Merging #752 (19f3fe2) into master (9960109) will increase coverage by 0.01%. The diff coverage is 0.00%.

:exclamation: Current head 19f3fe2 differs from pull request most recent head ec5934d. Consider uploading reports for the commit ec5934d to get more accurate results Impacted file tree graph

@@            Coverage Diff             @@
##           master     #752      +/-   ##
==========================================
+ Coverage   50.24%   50.25%   +0.01%     
==========================================
  Files         101      100       -1     
  Lines        8691     8689       -2     
==========================================
  Hits         4367     4367              
+ Misses       3471     3469       -2     
  Partials      853      853              
Impacted Files Coverage Δ
pkg/client/client.go 26.82% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 9960109...ec5934d. Read the comment docs.

codecov[bot] avatar Aug 17 '21 19:08 codecov[bot]

@ecordell: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci[bot] avatar Oct 13 '21 02:10 openshift-ci[bot]