operator-registry icon indicating copy to clipboard operation
operator-registry copied to clipboard

Add verify (tidy/lint) target

Open tmshort opened this issue 1 year ago • 3 comments

Added a verify target, to which other checks can be added. Added lint and tidy to the verify target. This will be used during github workflows/CI to make sure everything is "tidied". Updated the sanity check to use this verify target.

Description of the change:

Motivation for the change:

Reviewer Checklist

  • [ ] Implementation matches the proposed design, or proposal is updated to match implementation
  • [ ] Sufficient unit test coverage
  • [ ] Sufficient end-to-end test coverage
  • [ ] Docs updated or added to /docs
  • [ ] Commit messages sensible and descriptive

tmshort avatar Mar 29 '24 20:03 tmshort

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 54.01%. Comparing base (51ac823) to head (dc7da5e).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1247      +/-   ##
==========================================
- Coverage   54.02%   54.01%   -0.02%     
==========================================
  Files         108      108              
  Lines       11266    11266              
==========================================
- Hits         6087     6085       -2     
- Misses       4190     4192       +2     
  Partials      989      989              

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Mar 29 '24 20:03 codecov[bot]

How (‽‽) does this cover less code?

tmshort avatar Mar 29 '24 21:03 tmshort

/lgtm

everettraven avatar Apr 01 '24 13:04 everettraven

/approve

tmshort avatar Apr 01 '24 14:04 tmshort

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: everettraven, grokspawn, tmshort

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

openshift-ci[bot] avatar Apr 01 '24 14:04 openshift-ci[bot]

How (‽‽) does this cover less code?

using pentiums for the calc? ;)

grokspawn avatar Apr 01 '24 14:04 grokspawn