(feature) arbitrary base-version specification for mermaid upgrade-graph output
Description of the change: Provide the capability to pass a "start version" to serve as the smallest version to be included in a mermaid-format upgrade-graph render (... and then deal with the ripples through existing code/patterns).
Motivation for the change:
Reviewer Checklist
- [ ] Implementation matches the proposed design, or proposal is updated to match implementation
- [ ] Sufficient unit test coverage
- [ ] Sufficient end-to-end test coverage
- [ ] Docs updated or added to
/docs - [ ] Commit messages sensible and descriptive
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: grokspawn
The full list of commands accepted by this bot can be found here.
The pull request process is described here
- ~~OWNERS~~ [grokspawn]
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
Codecov Report
Merging #1013 (cc409c7) into master (d166a49) will decrease coverage by
0.10%. The diff coverage is48.43%.
:exclamation: Current head cc409c7 differs from pull request most recent head df2ec23. Consider uploading reports for the commit df2ec23 to get more accurate results
@@ Coverage Diff @@
## master #1013 +/- ##
==========================================
- Coverage 51.78% 51.67% -0.11%
==========================================
Files 102 102
Lines 9105 9153 +48
==========================================
+ Hits 4715 4730 +15
- Misses 3488 3515 +27
- Partials 902 908 +6
| Impacted Files | Coverage Δ | |
|---|---|---|
| alpha/declcfg/write.go | 65.27% <48.43%> (-17.02%) |
:arrow_down: |
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.
Going back to WIP to consider an alternative implementation approach Joe and I discussed out-of-band.
This PR describes it two different ways: specify a "base version" or specify a "start version", but I'm still not clear on what's being specified. Could you attach one of the created images here maybe that will make it clear?
This PR describes it two different ways: specify a "base version" or specify a "start version", but I'm still not clear on what's being specified. Could you attach one of the created images here maybe that will make it clear?
Oh okay the minimum-edge terminology and explanation make me understand what's going on much better now.
/lgtm