operator-registry icon indicating copy to clipboard operation
operator-registry copied to clipboard

(bug) fixing reliance on candidate channel containing all referenced bundles

Open grokspawn opened this issue 3 years ago • 2 comments

Signed-off-by: Jordan Keister [email protected]

Description of the change: opm alpha render-veneer semver is dependent on the Candidates channel including all bundles to be referenced in channel/edge creation. Instead, we need to build a list of all referenced bundles and pre-render them.

Closes #1008

Motivation for the change:

Reviewer Checklist

  • [ ] Implementation matches the proposed design, or proposal is updated to match implementation
  • [ ] Sufficient unit test coverage
  • [ ] Sufficient end-to-end test coverage
  • [ ] Docs updated or added to /docs
  • [ ] Commit messages sensible and descriptive

grokspawn avatar Aug 03 '22 19:08 grokspawn

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: grokspawn

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

openshift-ci[bot] avatar Aug 03 '22 19:08 openshift-ci[bot]

Codecov Report

Merging #1009 (a0e8537) into master (166ed6b) will decrease coverage by 0.03%. The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master    #1009      +/-   ##
==========================================
- Coverage   52.97%   52.94%   -0.04%     
==========================================
  Files         105      105              
  Lines        9606     9612       +6     
==========================================
  Hits         5089     5089              
- Misses       3562     3568       +6     
  Partials      955      955              
Impacted Files Coverage Δ
alpha/veneer/semver/semver.go 60.00% <0.00%> (-1.86%) :arrow_down:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

codecov[bot] avatar Aug 03 '22 19:08 codecov[bot]

/lgtm

bentito avatar Aug 23 '22 18:08 bentito

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot avatar Aug 24 '22 13:08 openshift-bot

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot avatar Aug 24 '22 13:08 openshift-bot

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot avatar Aug 24 '22 13:08 openshift-bot

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot avatar Aug 24 '22 13:08 openshift-bot

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot avatar Aug 24 '22 14:08 openshift-bot

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot avatar Aug 24 '22 14:08 openshift-bot

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot avatar Aug 24 '22 15:08 openshift-bot

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot avatar Aug 24 '22 15:08 openshift-bot

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot avatar Aug 24 '22 15:08 openshift-bot

/lgtm

bentito avatar Aug 24 '22 16:08 bentito

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot avatar Aug 24 '22 16:08 openshift-bot

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot avatar Aug 24 '22 16:08 openshift-bot

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot avatar Aug 24 '22 16:08 openshift-bot

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot avatar Aug 24 '22 17:08 openshift-bot