operator-marketplace
operator-marketplace copied to clipboard
operator-framework
Add client certificate and key to service monitor
Description of the change: Add client certificate and key to service monitor so that prometheus scraper does not depend on API server availability.
Motivation for the change: https://github.com/deads2k/openshift-enhancements/blob/master/enhancements/monitoring/client-cert-scraping.md
Reviewer Checklist
- [ ] Implementation matches the proposed design, or proposal is updated to match implementation
- [ ] Sufficient unit test coverage
- [ ] Sufficient end-to-end test coverage
- [ ] Docs updated or added to
/docs - [ ] Commit messages sensible and descriptive
Hi @xueqzhan. Thanks for your PR.
I'm waiting for a operator-framework member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.
Once the patch is verified, the new status will be reflected by the ok-to-test label.
I understand the commands that are listed here.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
![openshift-ci[bot] avatar](https://avatars.githubusercontent.com/in/91280?v=4 "Published by a pub.dev verified publisher"){kind=small}
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: perdasilva, xueqzhan
The full list of commands accepted by this bot can be found here.
The pull request process is described here
- ~~OWNERS~~ [perdasilva]
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
@xueqzhan: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:
| Test name | Commit | Details | Required | Rerun command |
|---|---|---|---|---|
| ci/prow/okd-e2e-gcp | 92622027c1c46a545516b9d83d883a27fa81c6ac | link | false | /test okd-e2e-gcp |
| ci/prow/okd-images | 92622027c1c46a545516b9d83d883a27fa81c6ac | link | true | /test okd-images |
Full PR test history. Your PR dashboard.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.
@perdasilva: Overrode contexts on behalf of perdasilva: ci/prow/okd-scos-images
In response to this:
/override ci/prow/okd-scos-images /lgtm
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.
@xueqzhan: This pull request explicitly references no jira issue.
In response to this:
Description of the change: Add client certificate and key to service monitor so that prometheus scraper does not depend on API server availability.
Motivation for the change: https://github.com/deads2k/openshift-enhancements/blob/master/enhancements/monitoring/client-cert-scraping.md
Reviewer Checklist
- [ ] Implementation matches the proposed design, or proposal is updated to match implementation
- [ ] Sufficient unit test coverage
- [ ] Sufficient end-to-end test coverage
- [ ] Docs updated or added to
/docs- [ ] Commit messages sensible and descriptive
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.
[ART PR BUILD NOTIFIER]
Distgit: marketplace-operator This PR has been included in build marketplace-operator-container-v4.18.0-202408010314.p0.g7949744.assembly.stream.el9. All builds following this will include this PR.
