operator-lifecycle-manager icon indicating copy to clipboard operation
operator-lifecycle-manager copied to clipboard

The good Makefile

Open perdasilva opened this issue 3 years ago • 4 comments

Signed-off-by: Per Goncalves da Silva [email protected]

Description of the change: This change updates the Makefile to display the different targets in a nice user friendly way. This still needs to be much more improved, but this is a good start.

Motivation for the change: Rukpak has a better Makefile than OLM

Reviewer Checklist

  • [ ] Implementation matches the proposed design, or proposal is updated to match implementation
  • [ ] Sufficient unit test coverage
  • [ ] Sufficient end-to-end test coverage
  • [ ] Docs updated or added to /doc
  • [ ] Commit messages sensible and descriptive
  • [ ] Tests marked as [FLAKE] are truly flaky
  • [ ] Tests that remove the [FLAKE] tag are no longer flaky

perdasilva avatar Apr 14 '22 12:04 perdasilva

@perdasilva: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci[bot] avatar Apr 19 '22 17:04 openshift-ci[bot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: exdx, perdasilva

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

openshift-ci[bot] avatar May 17 '22 13:05 openshift-ci[bot]

/lgtm (will reapply after a rebase)

exdx avatar May 17 '22 13:05 exdx

Holding so the bot doesn't go crazy.

/hold

timflannagan avatar May 17 '22 14:05 timflannagan

closing due to staleness

perdasilva avatar Feb 28 '23 09:02 perdasilva