operator-lifecycle-manager icon indicating copy to clipboard operation
operator-lifecycle-manager copied to clipboard

Add linux node selector to bundleUnpacker job

Open aimichelle opened this issue 2 years ago • 3 comments

Signed-off-by: Michelle Nguyen [email protected]

Description of the change: Added default nodeSelector "kubernetes.io/os": "linux" to the bundle unpacker job's pod template.

Motivation for the change: For the most part, we've noticed that OLM does a good job of adding the "kubernetes.io/os": "linux" node selector by default to most of the K8s resources it deploys. However, we've noticed the bundle unpacker job does not have any nodeSelector applied to it. In multi-OS environments, this can be a problem if this job starts up on a non-linux nodes.

Reviewer Checklist

  • [ ] Implementation matches the proposed design, or proposal is updated to match implementation
  • [ ] Sufficient unit test coverage
  • [ ] Sufficient end-to-end test coverage
  • [ ] Docs updated or added to /doc
  • [ ] Commit messages sensible and descriptive
  • [ ] Tests marked as [FLAKE] are truly flaky
  • [ ] Tests that remove the [FLAKE] tag are no longer flaky

aimichelle avatar Mar 09 '22 21:03 aimichelle

Hi @aimichelle. Thanks for your PR.

I'm waiting for a operator-framework member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci[bot] avatar Mar 09 '22 21:03 openshift-ci[bot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: aimichelle To complete the pull request process, please assign timflannagan after the PR has been reviewed. You can assign the PR to them by writing /assign @timflannagan in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

openshift-ci[bot] avatar Mar 09 '22 21:03 openshift-ci[bot]

@joelanford, @njhale , would either of you be able to take a look? Thank you!

aimichelle avatar Mar 22 '22 23:03 aimichelle

/ok-to-test

perdasilva avatar Feb 28 '23 09:02 perdasilva

/lgtm

perdasilva avatar Feb 28 '23 09:02 perdasilva

@aimichelle could you please update fix the failing unit test? FYI, I've rebased from this side.

perdasilva avatar Feb 28 '23 13:02 perdasilva

Thank you! Just pushed changes to the tests. Let me know if there's anything else you need. :)

aimichelle avatar Feb 28 '23 19:02 aimichelle

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aimichelle, perdasilva

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

openshift-ci[bot] avatar Apr 24 '23 11:04 openshift-ci[bot]

/lgtm

perdasilva avatar Apr 24 '23 12:04 perdasilva