operator-controller
operator-controller copied to clipboard
:sparkles: Add noopdelete option to extension api
Description
Solves #723
Reviewer Checklist
- [ ] API Go Documentation
- [ ] Tests: Unit Tests (and E2E Tests, if appropriate)
- [ ] Comprehensive Commit Messages
- [ ] Links to related GitHub Issue(s)
Deploy Preview for olmv1 ready!
| Name | Link |
|---|---|
| Latest commit | d0577134a3213ca76d53c5cd7b24521cd8836598 |
| Latest deploy log | https://app.netlify.com/sites/olmv1/deploys/662bca56bb76fd0008ea6abe |
| Deploy Preview | https://deploy-preview-772--olmv1.netlify.app |
| Preview on mobile | Toggle QR Code...Use your smartphone camera to open QR code link. |
To edit notification comments on pull requests, go to your Netlify site configuration.
Codecov Report
Attention: Patch coverage is 0% with 1 lines in your changes are missing coverage. Please review.
Project coverage is 67.12%. Comparing base (
9785be8) to head (2276f78). Report is 7 commits behind head on main.
| Files | Patch % | Lines |
|---|---|---|
| internal/controllers/extension_controller.go | 0.00% | 1 Missing :warning: |
Additional details and impacted files
@@ Coverage Diff @@
## main #772 +/- ##
==========================================
- Coverage 67.90% 67.12% -0.79%
==========================================
Files 22 22
Lines 1424 1466 +42
==========================================
+ Hits 967 984 +17
- Misses 391 416 +25
Partials 66 66
| Flag | Coverage Δ | |
|---|---|---|
| e2e | 45.42% <0.00%> (-0.92%) |
:arrow_down: |
| unit | 61.30% <0.00%> (-0.65%) |
:arrow_down: |
Flags with carried forward coverage won't be shown. Click here to find out more.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
I ✨ the PR title to pass the pr-title workflow, based on PR contents. This repo enforces naming along these lines: * ⚠ (:warning:, major/breaking change) * ✨ (:sparkles:, minor/compatible change) * 🐛 (:bug:, patch/bug fix) * 📖 (:book:, docs) * 🌱 (:seedling:, other)
If that's not correct, please choose the option that best fits.
make verify needs to be run before commiting.
I'm curious if there's a reason we're adding a new feature to the extension API, given that we're planning to focus on the cluster extension API and temporarily remove this API.
Should we just make this change directly on the ClusterExtension instead?
PR needs rebase.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.
Close or update/rebase for ClusterExtension?