operator-controller icon indicating copy to clipboard operation
operator-controller copied to clipboard

[HOLD] :warning: Bump ClusterExtension API to v1

Open perdasilva opened this issue 1 year ago β€’ 5 comments

Description

  • Updates ClusterExtension to v1
  • Adds operatorsv1alpha1 package alias for operators/v1alpha1
  • Does NOT update to catalogd v1 (as that's not merged or released yet)

Closes #1155

Reviewer Checklist

  • [ ] API Go Documentation
  • [ ] Tests: Unit Tests (and E2E Tests, if appropriate)
  • [ ] Comprehensive Commit Messages
  • [ ] Links to related GitHub Issue(s)

perdasilva avatar Sep 06 '24 15:09 perdasilva

Deploy Preview for olmv1 ready!

Name Link
Latest commit 05f03c6020187cbe89b040262f727873de6ee299
Latest deploy log https://app.netlify.com/sites/olmv1/deploys/6733bc3c0fbe080008eac482
Deploy Preview https://deploy-preview-1228--olmv1.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify[bot] avatar Sep 06 '24 15:09 netlify[bot]

Codecov Report

Attention: Patch coverage is 91.30435% with 6 lines in your changes missing coverage. Please review.

Project coverage is 74.76%. Comparing base (aaa0e00) to head (05f03c6). Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
internal/controllers/common_controller.go 82.35% 3 Missing :warning:
internal/applier/helm.go 75.00% 1 Missing :warning:
internal/contentmanager/sourcerer.go 0.00% 0 Missing and 1 partial :warning:
internal/resolve/resolver.go 0.00% 1 Missing :warning:
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1228      +/-   ##
==========================================
- Coverage   74.88%   74.76%   -0.13%     
==========================================
  Files          42       42              
  Lines        3241     3241              
==========================================
- Hits         2427     2423       -4     
- Misses        643      646       +3     
- Partials      171      172       +1     
Flag Coverage Ξ”
e2e 52.05% <81.15%> (ΓΈ)
unit 57.05% <66.66%> (-0.13%) :arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Sep 06 '24 16:09 codecov[bot]

@yashoza19 I just saw that you had your name down on the ticket to bump the API. I was on a bit of rampage today and didn't notice and went ahead and did it. I'm sorry about that. If it's helpful, please take what I've done here, otherwise, I'm happy to close. Apologies again =(

perdasilva avatar Sep 06 '24 17:09 perdasilva

@yashoza19 I just saw that you had your name down on the ticket to bump the API. I was on a bit of rampage today and didn't notice and went ahead and did it. I'm sorry about that. If it's helpful, please take what I've done here, otherwise, I'm happy to close. Apologies again =(

@perdasilva No worries at all. I was holding this issue off until we are done with all the other issues in epic-v1.

yashoza19 avatar Sep 06 '24 17:09 yashoza19

/hold

LalatenduMohanty avatar Sep 09 '24 20:09 LalatenduMohanty

I pushed a commit, which will hopefully clear up the CI failures.

joelanford avatar Nov 12 '24 17:11 joelanford

We will need another round of docs updates for this, but I think we should do that as a follow-up so that @m1kola's existing docs PRs don't need to be rebased.

joelanford avatar Nov 12 '24 17:11 joelanford

/hold cancel

everettraven avatar Nov 12 '24 20:11 everettraven