java-operator-sdk icon indicating copy to clipboard operation
java-operator-sdk copied to clipboard

Published 20 hours ago • verified publisher icon operator-framework

Expose dependent configuration for the case where we have several dependents of the same type

Open metacosm opened this issue 3 years ago • 2 comments

How do dependents work when we have more than one secondary resource (like having 3 deployments) ?

Originally posted by @sebastienblanc in https://github.com/java-operator-sdk/java-operator-sdk/pull/785#discussion_r787438396

metacosm avatar Jan 21 '22 12:01 metacosm

Thinking about this, I see two kinds of multiple dependents of same type:

  • fixed : the number of dependents is know at build time and a discriminating name should be enough. Dependents may be optional if the spec do not require it.
  • dynamic : the number of dependents is known at reconcile time and depends on the spec of the CR. This is often the case when a CR is a group. After having done such an operator, I do not think it is a good practice. The only pros is that it reduces the number of CRs. Having a lot of CRs and using PerResourcePolling with a low POLL_PERIOD could take down an external system.

scrocquesel avatar Jan 30 '22 19:01 scrocquesel

Yes, I tend to think that we should limit ourselves to the fixed case as a start and see how it goes and if we need to make it more dynamic.

metacosm avatar Jan 31 '22 08:01 metacosm

@csviri can you please point out the documentation or example code to see how this is working? Thanks a lot in advance!

andreaTP avatar Oct 04 '22 09:10 andreaTP

@csviri can you please point out the documentation or example code to see how this is working? Thanks a lot in advance!

@andreaTP pls take a look here: https://github.com/java-operator-sdk/java-operator-sdk/blob/9c1be9d59151f1673b5b2a5bea60543021fabd34/operator-framework/src/test/java/io/javaoperatorsdk/operator/sample/multiplemanageddependentsametype/MultipleManagedDependentResourceConfigMap1.java#L15-L15

Note that this is on next branch, and the api is going to change probably a little.

csviri avatar Oct 04 '22 10:10 csviri

Thanks for the pointer @csviri , does it make sense to provide "default" discriminators based on something pretty standard like labels?

andreaTP avatar Oct 04 '22 14:10 andreaTP

usually I think that would be based on rather some naming convention of the resource. So not sure. Might be if we seem some patterns.

csviri avatar Oct 04 '22 14:10 csviri

@csviri is this feature available now? If yes, could you please share some example code? (sorry, but example you've shared above is not very clear)

bachmanity1 avatar Oct 24 '22 09:10 bachmanity1

@bachmanity1 no, it will come with 4.1 (see milestone). It will be documented for that release too.

csviri avatar Oct 24 '22 09:10 csviri

@bachmanity1 no, it will come with 4.1 (see milestone). It will be documented for that release too.

ok, got it. Thanks for quick reply.

bachmanity1 avatar Oct 24 '22 09:10 bachmanity1