java-operator-sdk icon indicating copy to clipboard operation
java-operator-sdk copied to clipboard

Spotless plugin activation issue

Open csviri opened this issue 10 months ago • 3 comments

Now the spotless plugin does not activates on main. It was moved recently under a profile that should activate for the rood dir only:

 <profile>
      <id>spotless</id>
      <activation>
        <file>
          <exists>contributing</exists>
        </file>
      </activation>
      <build>
        <plugins>
          <plugin>
            <groupId>com.diffplug.spotless</groupId>
            <artifactId>spotless-maven-plugin</artifactId>
            <configuration>
              <pom>

 ...rest omitted  

But even if I run explicitly mvn spotless:apply it does not reformat code. Check is not working either that is why PRs are not catching this issue (./mvnw ${MAVEN_ARGS} spotless:check --file pom.xml )

csviri avatar Feb 22 '25 08:02 csviri

@xstefank would you be able to take a look pls? we can also temporarily revert this.

csviri avatar Feb 22 '25 08:02 csviri

@csviri I'll take a look, but I'm after wisdom teeth removal, so as soon as I can.

xstefank avatar Feb 22 '25 09:02 xstefank

@xstefank sure no hurry, might to some temporal revert for practical reasons. thank you!!

csviri avatar Feb 22 '25 09:02 csviri

This is fixed now, closing.

csviri avatar Jun 23 '25 07:06 csviri