java-operator-sdk icon indicating copy to clipboard operation
java-operator-sdk copied to clipboard

Every EventSource should be a ResourceEventSource

Open csviri opened this issue 2 years ago • 2 comments

Currently even for inbound event sources that is support for event triggering the reconciliation where the event does not contain the actual resource we have a supporting class that actually fetches the resource (within the event source):

https://github.com/java-operator-sdk/java-operator-sdk/blob/47ef983dd4135a05fd6c2cd0650cf0eda1fd3c8e/operator-framework-core/src/main/java/io/javaoperatorsdk/operator/processing/event/source/inbound/CachingInboundEventSource.java

The question is if it makes sense to even have a non resource event source. Probably not. We have to discuss this, and probably change (thus move the API of ResourceEventSource to EventSource) for next major version .

csviri avatar Oct 24 '23 14:10 csviri

This issue is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 14 days.

github-actions[bot] avatar Dec 24 '23 01:12 github-actions[bot]

This issue is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 14 days.

github-actions[bot] avatar Feb 23 '24 01:02 github-actions[bot]