How to selectively define the fields to reconcile with DependentResources

[andreaTP]

Bug Report

Defining a DependenResource of type e.g. Job is slightly problematic at a first attempt. The reason is that the Job .spec.template field is immutable and any update operation slightly changing it result in an error.

Here I'm tentatively disabling all the update methods: https://github.com/andreaTP/bink8s/blob/0177a66e4b31225c0b5a91e5694e80a3d3127df4/src/main/java/io/bink8s/controller/workflow/ImageBuildJobDependentResource.java#L85-L97

I'm not sure what would be the best course of action here, e.g. Labels can still be updated/reconciled, but we should make sure the .spec.template remains untouched. The problematic bit is that .spec.template contains elements that are filled after the object is created e.g.:

spec:
  template:
    metadata:
      creationTimestamp: null
      labels:
        controller-uid: 7ec0fb0f-d0fa-4795-b051-233d8d40f19c

I'm looking for guidance on how to handle this situation properly 🙏

[csviri]

We don't have a Job specific matcher yet, but this can be probably just fixed if you override the matcher.

What is your exact use case?

Asking because recreating a use case is not supported, what might be an use case some times.

[andreaTP]

I would like to simply skip the update if .spec.template differ, and, to make sure I never update that subpath (as it will result in an error all the time).

[csviri]

Ahh ok, this is defintely should be possible to do even now, just overriding the match and the update function.

However might be easier if the desired would receive the actual resource too if present. cc @metacosm - will prepare a PR for this.

[csviri]

@andreaTP I linked a PR, we can discuss that. Basically now this is possible just more hacky, with that it should be doable much more elegantly. Probably the best would be to add to the same branch an integration test for this use case.

[github-actions[bot]]

This issue is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 14 days.

[github-actions[bot]]

This issue was closed because it has been stalled for 14 days with no activity.

[csviri]

I was updating the API for this use case, see related PR. But realized that getSecondaryResource always can be called. So you can just call that set the spec.template part from there if present. In this case it is not changed. Not sure if we should still change the API of desired. Will create an example at least.

[csviri]

See sample here: https://github.com/java-operator-sdk/java-operator-sdk/pull/1746

I think this is good enough, no need to explicitly put the resource in to desrire(...) api. Unless you think otherwise @andreaTP or @metacosm