helm-operator-plugins icon indicating copy to clipboard operation
helm-operator-plugins copied to clipboard

Bump Kubebuilder to v4

Open Neo2308 opened this issue 1 year ago • 1 comments

  • Bump kubebuilder v3 -> v4.
  • Add copy of helper functions which were removed upstream. (https://github.com/kubernetes-sigs/kubebuilder/pull/3920)
  • Remove kube-rbac-proxy. (https://github.com/kubernetes-sigs/kubebuilder/pull/3899)
  • Remove component config support. (https://github.com/kubernetes-sigs/kubebuilder/pull/3764 & https://github.com/kubernetes-sigs/kubebuilder/pull/3916)
  • Update inconsistent spacing in marker annotations (https://github.com/kubernetes-sigs/kubebuilder/pull/3904)
  • Regenerate test-data

Summary of all breaking changes in Kubebuilder v3->v4 can be found at https://github.com/kubernetes-sigs/kubebuilder/releases/tag/v4.0.0

Relates to https://github.com/operator-framework/operator-sdk/issues/6730

Neo2308 avatar Jun 18 '24 07:06 Neo2308

Codecov Report

Attention: Patch coverage is 28.57143% with 5 lines in your changes missing coverage. Please review.

Project coverage is 52.01%. Comparing base (08ab7fb) to head (06c06d5). Report is 35 commits behind head on main.

Files Patch % Lines
pkg/plugins/util/helpers.go 50.00% 2 Missing :warning:
pkg/plugins/helm/v1/api.go 0.00% 1 Missing :warning:
pkg/plugins/helm/v1/init.go 0.00% 1 Missing :warning:
pkg/plugins/hybrid/v1alpha/init.go 0.00% 1 Missing :warning:

:exclamation: There is a different number of reports uploaded between BASE (08ab7fb) and HEAD (06c06d5). Click for more details.

HEAD has 1 upload less than BASE
Flag BASE (08ab7fb) HEAD (06c06d5)
2 1
Additional details and impacted files
@@             Coverage Diff             @@
##             main     #346       +/-   ##
===========================================
- Coverage   85.06%   52.01%   -33.06%     
===========================================
  Files          19       66       +47     
  Lines        1346     3232     +1886     
===========================================
+ Hits         1145     1681      +536     
- Misses        125     1448     +1323     
- Partials       76      103       +27     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov-commenter avatar Jul 29 '24 22:07 codecov-commenter

@acornett21 / @joelanford need help with this PR. How can we resolve the go-apidiff job failures?

Neo2308 avatar Aug 20 '24 09:08 Neo2308

Hi @Neo2308 please see my comment on this other PR.

https://github.com/operator-framework/helm-operator-plugins/pull/377#issuecomment-2297076776

acornett21 avatar Aug 20 '24 14:08 acornett21

This is no longer needed...closing.

acornett21 avatar Aug 26 '24 21:08 acornett21