api

api copied to clipboard

RFE: good practices validator only warn for empty CRD desc if spec.customresourcedefinitions in csv is not empty

1

https://github.com/operator-framework/api/blob/28c6773d2b746559369035cfa3d211360706a247/pkg/validation/internal/good_practices.go#L243 This warning is always returned, even when you are not using the `customresourcedefinitions` field. Example: ```yaml spec: apiservicedefinitions: {} customresourcedefinitions: {} ``` It's even in the docs where the...

HarikrishnanBalagopal

Converting an operator group object to an unstructured object causes a panic

2

This works with the v1alpha1 types that I have tried (ClusterServiceVersion, Subscription, CatalogSource) but not OperatorGroups. I've included a minimal example to trigger the panic but it also panics when...

MaxMcAdam

Godoc missing from Subscription API

1

The `Subscription` API (v1alpha1) is missing godoc descriptions for `SubscriptionSpec` fields. Godoc descriptions for APIs can help clarify the behavior of OLM subscriptions. The `startingCSV` field in particular needs a...

adambkaplan

Serializing Subscription resources without including "status" field?

1

I would like to serialize a Subscription resource to YAML using code like this: ``` subscription := operatorsv1alpha1.Subscription{ TypeMeta: metav1.TypeMeta{ APIVersion: operatorsv1alpha1.SubscriptionCRDAPIVersion, Kind: operatorsv1alpha1.SubscriptionKind, }, ObjectMeta: metav1.ObjectMeta{ Namespace: namespaceName, Name:...

larsks

The multiarch validator should not warning when only linux.amd64 platform is found

2

Example: ``` $ operator-sdk bundle validate ./testdata/go/v3/memcached-operator/bundle/ --select-optional name=multiarch WARN[0017] Warning: Value memcached-operator.v0.0.1: unable to inspect the image (quay.io/example/memcached-operator:v0.0.1) : docker pull quay.io/example/memcached-operator:v0.0.1 failed with error: (exit status 1) Error...

camilamacedo86

Catalog source poll is not required if the image refers to a digest

1

We can add an additional check at https://github.com/operator-framework/api/blob/master/pkg/operators/v1alpha1/catalogsource_types.go#L287 to see if image has `@sha` as I believe the polling to see the update is required only there is scope of...

ashishth09

Is there a reason that we're not using the regex from [semver](https://semver.org/)? here: > "([0-9]+)\\.([0-9]+)\\.([0-9]+)(?:-([0-9A-Za-z-]+(?:\\.[0-9A-Za-z-]+)*))?(?:\\+[0-9A-Za-z-]+)?$" there: > "^(0|[1-9]\d*)\.(0|[1-9]\d*)\.(0|[1-9]\d*)(?:-((?:0|[1-9]\d*|\d*[a-zA-Z-][0-9a-zA-Z-]*)(?:\.(?:0|[1-9]\d*|\d*[a-zA-Z-][0-9a-zA-Z-]*))*))?(?:\+([0-9a-zA-Z-]+(?:\.[0-9a-zA-Z-]+)*))?$" This one does not work for prerelease versions, right? I realize that...

grokspawn

[Validators] - Review and improve warn/error message in order to provide how to sort them out

1

**Description** See an example of the warns/issues raised by the validators: https://github.com/redhat-openshift-ecosystem/community-operators-pipeline/pull/252#issuecomment-1138534471 The goal of this task is to ensure that all messages contain what is wrong/or could be improved...

camilamacedo86

Improve the default bundle validation - Inform when the entries are duplicated

1

### What If we duplicate entries for the owned.crd then the error bellow will be faced: ``` ERRO[0000] Error: Value ceph.rook.io/v1, Kind=CephCluster: owned CRD "ceph.rook.io/v1, Kind=CephCluster" not found in bundle...

camilamacedo86

ClusterServiceVersionValidator is not raising errors when the annotations are duplicated

3

**Description** ClusterServiceVersionValidator is not raising errors when the annotations are duplicated The e.g scenario can be found in: https://github.com/redhat-openshift-ecosystem/community-operators-prod/pull/1121/files#diff-c0ad3966e15bf1757f16f02b664a3093ebf00f0e74956753ee48de223996268c See that community is calling the bundle to validate and it...

camilamacedo86