Pavel Iatchenii

Results 23 comments of Pavel Iatchenii

@MartinNowack thank you for your time. I pushed the branch again, so we can test changes for LLVM 12. As regards design, should we implement `__ubsan_*` functions in its own...

@MartinNowack I used to know 6 months ago 😄 As far as I remember, the behavior of `__ubsan_handle_pointer_overflow` had been changing. Although mainly new handlers are being added, you are...

@MartinNowack Thanks for the tips. I pushed a version with a new runtime library `UBSan` containing handlers and some more. Let me put some code decisions below: - Sources of...

@MartinNowack That's good to hear feedback from you again! I have rebased changes so that branch is ready to be merged now. Some important notes with regard to the future...

I also noticed that you plan to remove support of LLVM < 6 in PR #1446. Please, bear in mind its support in current PR.

@MartinNowack I am not sure if you receive notifications from the review that I started. Could you give a piece of advice about the above-mentioned minor issue?

@MartinNowack I am glad we have an understanding. Do you have anything to add to the reviews we started above?

@MartinNowack Thank you for the tip. I hope that I took it in the right way and solved the issue. All in all, I introduced 3 new categories: 1. _ImplicitConversion_...

> Can't you split this into subcategories? @ccadar Sure, I pointed to the piece of code, where it's implemented.

@ccadar Thanks, makes sense. > From what I see you are not using the recent categories introduced by #1343. How do I use categories correctly? Do I need to include...