zipkin4net icon indicating copy to clipboard operation
zipkin4net copied to clipboard

Published 20 hours ago • verified publisher icon openzipkin

B3SingleFormat.FormatMaxLength short by 1

Open yanxke opened this issue 4 years ago • 2 comments

https://github.com/openzipkin/zipkin4net/blob/63976c5325f36c38df3a3b237f10a9ac2e33f482/Src/zipkin4net/Src/Propagation/B3SingleFormat.cs#L39

Right now it adds up to 67. Should be 68.

yanxke avatar Dec 27 '20 00:12 yanxke

I don't understand the exact problem here. Can you elaborate?

nnminh98 avatar Apr 02 '23 18:04 nnminh98

If you look at the sample https://github.com/openzipkin/zipkin4net/blob/63976c5325f36c38df3a3b237f10a9ac2e33f482/Src/zipkin4net/Src/Propagation/B3SingleFormat.cs#L22 it is 68 characters long, but this is defined to only hold 67 characters.

yanxke avatar Apr 03 '23 01:04 yanxke