zipkin4net icon indicating copy to clipboard operation
zipkin4net copied to clipboard

Implement ConfigureAwait(false)

Open hallidev opened this issue 4 years ago • 0 comments

I'm working in a fairly large codebase that's using this dreaded pattern:

string result = response.Content.ReadAsStringAsync().Result;

As a result, line 67 in InOrderAsyncQueueDispatcher.cs reliably deadlocks :

_eventSlim.Wait(_cancellationTokenSource.Token);

I've added ConfigureAwait(false) to a few key code paths for my use case and it resolves the issue. This should be done throughout the solution.

I can put together a PR if you like. I just wanted to know if you were okay with that / in agreement.

hallidev avatar Jun 18 '20 18:06 hallidev