zipkin icon indicating copy to clipboard operation
zipkin copied to clipboard

Initial commit for Postgres backend support

Open dwelch2344 opened this issue 2 years ago • 4 comments

Opening this up for review in response to https://github.com/openzipkin/zipkin/issues/1232

Saw the rejected PR https://github.com/openzipkin/zipkin/pull/3228

Open to suggestions on reworking the schema for better storage. IMO the combination of index + structure should hold decent performance, and outside of actually using referential integrity (fk's and the like) I'm keen to try it as is. If performance became a problem, setting a minimum version of pg 10-12 + leveraging table partitioning would probably do a pretty good job to break up the data enough.

Thoughts? @codefromthecrypt know you've been big on keeping this maintainable for future so happy to collaborate :)

dwelch2344 avatar Jun 21 '22 05:06 dwelch2344

I'm swamped in my new world of wasm, so won't be able to chime in or help support this. Folks currently on the show might decide differently than my previous opinions, so I'll leave it up to them!

codefromthecrypt avatar Jun 21 '22 06:06 codefromthecrypt

Awaiting this feature to get merged !!

metalhead44 avatar Jul 16 '22 18:07 metalhead44

+1

bvo42 avatar Jul 26 '22 11:07 bvo42

Any news regarding this PR ? I would be interested by the functionality.

wilvdb avatar Sep 13 '22 13:09 wilvdb

Hi people. Thanks for showing interest on this feature. At the moment I don't think we have enough capacity to support a new storage in the core repo. How about moving this code to a repository where people can consume and try out and then when prooved to work we move to the contrib section?

In my experience working out a storage implementation isn't an easy task and hence we better do it carefuly.

jcchavezs avatar Oct 26 '22 08:10 jcchavezs