zipkin icon indicating copy to clipboard operation
zipkin copied to clipboard

Make SpanDetail component simple and use TypeScript

Open tacigar opened this issue 3 years ago • 4 comments

SpanDetail component displays the details of a particular span. This component has been more complicated than it needed to be. So this PR did the followings

  • Make SpanDetail component simple
  • Use TypeScript for SpanDetail (it has been written in JavaScript)

Before

スクリーンショット 2021-04-02 1 45 20

After

スクリーンショット 2021-04-02 1 42 00

tacigar avatar Apr 01 '21 16:04 tacigar

Thanks @tacigar I think it looks much simpler and clean, however I am concerned the annotations can't be seen in context as timestamp is less meaningful than seeing them over the span duration. Any chance we can get that back?

jcchavezs avatar Apr 14 '21 11:04 jcchavezs

@jcchavezs Thank you for your feedback!

I'm currently redeveloping trace graph in this PR (https://github.com/openzipkin/zipkin/pull/3350). In this PR, the trace graph looks like this and annotation is drawn by white line. This may be helpful.. I'm not sure..

113511654-d7ec7700-959b-11eb-8ee0-7d17e7e452b0

tacigar avatar Apr 15 '21 08:04 tacigar

Hi @tacigar the "white striped" annotations on the spans is a good idea, however this will not be enough to replace the span bar with annotation items in the SpanDetail view. Especially in large traces it will be difficult to see the annotations in the trace view. I would keep the idea and restyle to fit between the Annotations header and the annotations table. So make it collapsible together with the table if people want a tag/key only view.

basvanbeek avatar Apr 15 '21 12:04 basvanbeek

I see...make sense! I'll update the design 🙇‍♂️ Thank you for your feedback! @basvanbeek

tacigar avatar Apr 19 '21 14:04 tacigar