openzipkin
WIP eureka
Don't think this is ready yet, as there are some gaps
@minwoox can you help champion this one?
Fixes #1870
Are you up to taking it over?
On Mon, Feb 21, 2022, 10:17 agilis allievo @.***> wrote:
This MR seems dormant, is anyone still working on it?
— Reply to this email directly, view it on GitHub https://github.com/openzipkin/zipkin/pull/3316#issuecomment-1046640238, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAXOYAXQ5XK34M4ULD44HELU4H7LTANCNFSM4T7D6F4Q . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.
You are receiving this because you are subscribed to this thread.Message ID: @.***>
the problems here were mostly test lifecycle in nature (properties read at the wrong time), so https://github.com/openzipkin/zipkin/pull/3671 walked around them by using testcontainers+dynamic properties instead of nested initialization. https://github.com/openzipkin/zipkin/blob/master/zipkin-server/src/test/java/zipkin2/server/internal/eureka/ITZipkinEureka.java