zipkin icon indicating copy to clipboard operation
zipkin copied to clipboard

Use html tags for rendering trace graph instead of svg

Open tacigar opened this issue 4 years ago • 0 comments

Currently, svg is used for the trace graph. This was implemented for rendering speed.

However, normal css cannot be used with svg, e.g. text-overflow. This creates some rendering issues like https://github.com/openzipkin/zipkin/issues/2948 .

The problem of rendering speed can be solved by virtualization like using react-virtualized (https://github.com/bvaughn/react-virtualized). So I think we should give priority to ease of drawing rather than drawing speed.

At first glance, svg is very good for drawing complex graphs flexibly, but it can be difficult to do finer things. I think we should draw the chart with normal html tags & css, even if it's a bit painful at first. Trace graphs are not as complex as they cannot be drawn with html & css.

tacigar avatar Mar 03 '20 03:03 tacigar