zipkin-js

zipkin-js copied to clipboard

isOptional and Related checks are wrong and breaks compatibility between versions

5

Namaste Team The `isOptional` check seems to breaking our version compatibility. Our projects use v `0.19` and `0.22` and we have been trying to figure why is our tracing broken...

whizzzkid

Add Propagation interface

13

Hi guys, i was thinking to add the Propagation interface like (https://github.com/openzipkin/brave/blob/master/brave/src/main/java/brave/propagation/Propagation.java), to support other propagation headers like f.e x-amzn-trace-id or b3 simple 😄.

asanluis

What should be unique traces are all getting same traceId with the axios instrumentation

1

So all I'm doing is integrating at the axios level in ONE place. There is nothing downstream adding spans. This is simply ONE place where I've added axios (web-service call)...

jeffthompson1971

How can I add tags per request?

16

I have this working, but i need to pass in a couple specific tags like username etc so i know who the trace is for. I don't see a way...

jeffthompson1971

Adds support for http.route based name

2

Currently http middlewares use the `http method` for naming spans. This solution is a not so bad low cardinality option, however from user perspective this could be improved by using...

jcchavezs

Create Documentation

1

Maybe create a documentation page with docusaurus, docsify or something like it. We could publish it on github pages. [link for docusaurus](https://docusaurus.io/) [link for docsify](https://docsify.js.org/)

DavideCarvalho

gotjs intrumentation is not working

3

While testing with gotjs instrumentation, I am running into issues. ```javascript import wrapGot from "zipkin-instrumentation-gotjs"; const gotAPI = wrapGot(got, {tracer, serviceName:config.serviceName , remoteServiceName:"my-service"}); ``` the build works fine, but at...

vtapadia

The http.url tag was the default record for http requests but we changed it into http.path due to privacy issues. There are a couple of request for it from @maumercado...

jcchavezs

Allow adding arbitrary tags on span

1

I'd like to be able to add tags on a span, at runtime. Similar to what `brave` does https://github.com/openzipkin/brave/blob/master/brave/README.md#customizing-spans ``` span.tag("clnt/finagle.version", "6.36.0"); ```

maximede

Spans are mixed on concurrent async calls on a Hapi server

11

We use zipkin-js to observe our Hapi server and its dependencies and we noticed that when we get multiple concurrent calls, some of the spans are getting assigned to the...

scabfos