zipkin-js icon indicating copy to clipboard operation
zipkin-js copied to clipboard

Fix bug where exceptions in other middleware are being swallowed

Open phelma opened this issue 1 year ago • 1 comments

In zipkin-instrumentation-koa, by calling next().catch() we catch any exceptions in the next middleware if we are going to catch them we should throw again so that they can be handled elsewhere.

phelma avatar Mar 29 '23 15:03 phelma

is there a way we can update the tests so they fail without this fix?

codefromthecrypt avatar Feb 09 '24 01:02 codefromthecrypt