brave icon indicating copy to clipboard operation
brave copied to clipboard

Published 20 hours ago • verified publisher icon openzipkin

issue-1340: finish grpc span in TracingServerCallListener#onCancel

Open osadchuk-roman opened this issue 2 years ago • 6 comments

osadchuk-roman avatar Aug 19 '22 12:08 osadchuk-roman

related to https://github.com/openzipkin/brave/issues/1340

osadchuk-roman avatar Aug 19 '22 12:08 osadchuk-roman

Could you add a failing test?

jcchavezs avatar Aug 26 '22 10:08 jcchavezs

Could you add a failing test?

done

osadchuk-roman avatar Aug 29 '22 11:08 osadchuk-roman

@jcchavezs could you please start pr workflow again?

osadchuk-roman avatar Sep 06 '22 09:09 osadchuk-roman

@jcchavezs Is this PR good for merging? If yes - please merge it

ajax-osadchuk-r avatar Sep 23 '22 08:09 ajax-osadchuk-r

I still don't see the failing test case :(.

jcchavezs avatar Sep 23 '22 10:09 jcchavezs

Friendly ping @ajax-osadchuk-r

jcchavezs avatar Oct 26 '22 08:10 jcchavezs

closing as without a test this isn't something to merge. we need to know the lifecycle relationship between onCancel and onHalfClose, specifically this assumes the latter isn't called.

codefromthecrypt avatar Dec 15 '23 12:12 codefromthecrypt