brave
brave copied to clipboard
openzipkin
Add missing method in TracingConsumer to support Kafka 3.2.0+
To allow supporting newer versions of Kafka, would it be possible to upgrade the TracingConsumer by adding the following method
void enforceRebalance(final String reason);
This method has been added in Kafka 3.2.0.
Source code of the Consumer interface with the new method can be found here https://github.com/apache/kafka/blob/3.2.0/clients/src/main/java/org/apache/kafka/clients/consumer/Consumer.java#L264
My current project using Spring Boot 2.7.2, Kafka 3.2.1 and Brave 5.13.9 had the issue which has been fixed by adding this new method locally. No other issues have been detected when using Kafka 3.2.1.
Any feedbacks are more than welcome on this issue. I may eventually contribute by dropping a PR.
Of course contributions are welcome. Ping @jeqo
On Tue, 2 Aug 2022, 23:07 François Rosière, @.***> wrote:
To allow supporting newer versions of Kafka, would it be possible to upgrade the TracingConsumer by adding the following method
void enforceRebalance(final String reason);
This method has been added in Kafka 3.2.0.
Source code of the Consumer interface with the new method can be found here
https://github.com/apache/kafka/blob/3.2.0/clients/src/main/java/org/apache/kafka/clients/consumer/Consumer.java#L264
My current project using Spring Boot 2.7.2, Kafka 3.2.1 and Brave 5.13.9 had the issue which has been fixed by adding this new method locally. No other issues have been detected when using Kafka 3.2.1.
Any feedbacks are more than welcome on this issue. I may eventually contribute by dropping a PR.
— Reply to this email directly, view it on GitHub https://github.com/openzipkin/brave/issues/1338, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAXOYATUWYGC2QJVN76JLUDVXGEZZANCNFSM55MR5I6Q . You are receiving this because you are subscribed to this thread.Message ID: @.***>
Question: if we upgrade the Kafka version in the Brave library to 3.2.1, will it still work with previous versions of Kafka? I suppose the fact to not use the Override annotation is for this reason?! On top of that, the Kafka dependency is using the provided scope... (version defined in root pom is 3.0.0) If it's confirmed, the fix is quite easy.
@frosiere yes, that's the approach we have follow so far to avoid breaking previous versions.
