zipkin-ui icon indicating copy to clipboard operation
zipkin-ui copied to clipboard

When the zipkin host isn't localhost..

Open codefromthecrypt opened this issue 8 years ago • 8 comments

from @dragontree101

my zipkin-server is 1.16 and change zipkin-ui in 0.0.1 i use new zipkin-ui, but has error, i need change some ui-config?

i use config is

environment=
  KAFKA_ZOOKEEPER="10.215.242.11,10.215.242.12,10.215.242.13:2181/kafka-offline",
  STORAGE_TYPE="elasticsearch",
  SELF_TRACING_ENABLED="true",
  ES_CLUSTER="prod",
  ES_HOSTS="http://10.215.242.15:9200",
  ES_PIPELINE="zipkin",
  KAFKA_STREAMS="4",
  QUERY_PORT="8080"

image

i think to change localhost to zipkin-server's ip? i am not deploy zipkin-server in my local.

codefromthecrypt avatar Dec 29 '16 09:12 codefromthecrypt

looking at the code, it seems there are some constants relating to the fully-qualified api host. is there a way to use a relative path instead? (forgive me, if I misunderstand them)

codefromthecrypt avatar Dec 29 '16 09:12 codefromthecrypt

I am in the same boat , How can I have the localhost replaced with the relative path

jprateekvmware avatar Jan 21 '17 03:01 jprateekvmware

this is just waiting on work to do it. does anyone have time to help?

codefromthecrypt avatar Jan 21 '17 03:01 codefromthecrypt

What's the general idea for configuring this UI?

I see that docker-zipkin uses a nginx to proxy the actual backend onto the same server that hosts the UI, and ZipkinService hardcodes 'localhost' and the port here: https://github.com/openzipkin/zipkin-ui/blob/master/src/app/zipkin/zipkin.ts#L155

Seems that one needs to do two things: kill the port reference there, and then fix all places that work with localhost?

ankon avatar Feb 22 '17 14:02 ankon

@ankon so when in development (and also many sites), the port is 9411. So, I supposed some means of configuring the api endpoint ex (http://localhost:9411) would be what's needed. Then, whatever parameter is needed would be passed to the deployment.

One idea is to expose the api endpoint as a part of config.json, which is how the old UI gets its config, lacking that assume http://localhost:9411. There is a chicken/egg problem, of course as config.json is served by the host listening on 9411!

TL;DR; I don't know the best way, but what you've mentioned makes sense.

cc @openzipkin/devops-tooling

codefromthecrypt avatar Feb 27 '17 04:02 codefromthecrypt

@charlescui made a suggestion here https://github.com/openzipkin/docker-zipkin/issues/134#issuecomment-288403568

codefromthecrypt avatar Mar 22 '17 14:03 codefromthecrypt

here's an example implementation https://github.com/openzipkin/zipkin-ui/pull/34 I think others should comment wrt the configuration approach.

codefromthecrypt avatar Mar 23 '17 03:03 codefromthecrypt

#34 suggests separate env variables to assign this.. like export ZIPKIN_HOST=172.16.10.56 ZIPKIN_PORT=32008 please give feedback if this works for you or not.

codefromthecrypt avatar Mar 23 '17 07:03 codefromthecrypt