zimit icon indicating copy to clipboard operation
zimit copied to clipboard

wombatSetup.js from warc2zim is not up-to-date in dev image

Open benoit74 opened this issue 9 months ago • 13 comments

Currently, we do not use a released package of warc2zim but we build it from source since the dependency is warc2zim @ git+https://github.com/openzim/warc2zim@main

The drawback is that for now warc2zim build does not contains the build responsible to update wombatSetup.js from JS code.

This is handled manually and separately in warc2zim CI due to the associated complexities (we need a Node environment).

When using a released package of warc2zim, the latest wombatSetup.js is built by warc2zim CI and included in both sdist and wheel packages.

Since we are not using a released package of warc2zim, our version of wombatSetup.js is outdated since we fallback to the "non-official" file located at https://dev.kiwix.org/warc2zim/wombatSetup.js

Do we wanna fix this or is it not worth it since anyway we are not supposed to use unreleased versions of warc2zim?

benoit74 avatar May 24 '24 14:05 benoit74