zim-tools icon indicating copy to clipboard operation
zim-tools copied to clipboard

Add macOS 14 ARM in the CI

Open kelson42 opened this issue 1 year ago • 8 comments

We need to check and provide zim-tools on macOS for Mx family

kelson42 avatar Jun 02 '24 15:06 kelson42

Codecov Report

:white_check_mark: All modified and coverable lines are covered by tests. :white_check_mark: Project coverage is 26.97%. Comparing base (fab5063) to head (9c42cbd). :warning: Report is 71 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #412      +/-   ##
==========================================
- Coverage   27.01%   26.97%   -0.05%     
==========================================
  Files          26       26              
  Lines        2458     2458              
  Branches     1339     1340       +1     
==========================================
- Hits          664      663       -1     
  Misses       1305     1305              
- Partials      489      490       +1     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

codecov[bot] avatar Jun 02 '24 15:06 codecov[bot]

@mgautierfr Why libzim is not available in the dependences?

kelson42 avatar Jun 02 '24 15:06 kelson42

PR always require a description 😉

Why libzim is not available in the dependences?

Because you search in x86_64 directories (https://github.com/openzim/zim-tools/pull/412/files#diff-b803fcb7f17ed9235f1e5cb1fcd2f5d3b2838429d4368ae4c57ce4436577f03fR61-R62) and it is not the right directory for aarch64. It should be BUILD_arm64-apple-macos

mgautierfr avatar Jun 03 '24 09:06 mgautierfr

@mgautierfr Thx, not it seems we face another problem as it seems it is still not able to link properly

kelson42 avatar Jun 03 '24 10:06 kelson42

@mgautierfr ?

kelson42 avatar Jun 15 '24 18:06 kelson42

@mgautierfr Help needed?

kelson42 avatar Aug 06 '24 05:08 kelson42

@rgaudin Would you be able pleae to confirm that BUILD_arm64-apple-macos/INSTALL/lib/libxapian.a from https://tmp.kiwix.org/ci/deps_macos-aarch64-dyn_zim-tools.tar.gz is a binary made for arm64/aarch74? To me this would be the only explaination behind the error.

kelson42 avatar Aug 24 '24 13:08 kelson42

❯ lipo -info BUILD_arm64-apple-macos/INSTALL/lib/libxapian.a
Non-fat file: BUILD_arm64-apple-macos/INSTALL/lib/libxapian.a is architecture: arm64

It looks like you're missing compression stuff ; probably zlib

rgaudin avatar Aug 26 '24 15:08 rgaudin

Superseeded by #483

kelson42 avatar Nov 05 '25 03:11 kelson42