zim-requests icon indicating copy to clipboard operation
zim-requests copied to clipboard

Open Music Theory

Open gfojose opened this issue 4 years ago • 19 comments

  • Website URL: http://openmusictheory.com/
  • License: CC BY-SA 4.0
  • Desired ZIM Title: Open Music Theory
  • Desired ZIM Description: Open Music Theory is an open-source, interactive, online “text”book for college-level music theory courses.
  • Desired ZIM Icon –png (URL or attach one): Couldn't really find one
  • Language (ISO 639-3): eng
  • Desired Main Page (homepage, if different from website URL): n/a
  • Is this a MediaWiki?: no

gfojose avatar Jan 05 '21 03:01 gfojose

File is ready at the library https://library.kiwix.org/viewer#openmusictheory.com_2024-03/A/openmusictheory.github.io/contents.html

RavanJAltaie avatar Apr 19 '24 11:04 RavanJAltaie

@RavanJAltaie JavaScript is not working

Not only the js, the whole CSS is missing for me!

kelson42 avatar Apr 20 '24 12:04 kelson42

This is what I see in the file: https://github.com/openzim/zim-requests/assets/116940574/edac1405-ec6f-41b8-acb8-758b8a6b883b @benoit74 I checked with Stephane and he is getting a different result. @Popolechien please upload your video.

RavanJAltaie avatar Apr 23 '24 19:04 RavanJAltaie

Here is what I get (both on macOS and Windows, Chrome) image

Here is what I get on Windows11/Firefox image

Popolechien avatar Apr 23 '24 19:04 Popolechien

@benoit74 could you please have a look?"

RavanJAltaie avatar Apr 29 '24 23:04 RavanJAltaie

I think that the issue is you did not pushed the proper link and then kiwix-serve struggles to server the content properly.

Proper link is https://library.kiwix.org/viewer#openmusictheory.com_2024-03/ or https://library.kiwix.org/content/openmusictheory.com_2024-03/ (with zimit1 the link we provide must always end with the ZIM name and not contain anything else)

@Popolechien could you confirm you tried directly with the wrong link provided a few comments above, and check again with these proper links?

benoit74 avatar Apr 30 '24 10:04 benoit74

Looks good with the "proper" link you provided (Chrome, windows 11). Tests I ran were with the link in @RavanJAltaie 's closing comment here

Popolechien avatar Apr 30 '24 10:04 Popolechien

Tests I ran were with the link in @RavanJAltaie 's closing comment https://github.com/openzim/zim-requests/issues/313#issuecomment-2066376374

I assumed so, this is what I emphasize that when providing link for Zimit1 it must end with the ZIM at the end and nothing more. Basically the link you have on library search page (where you search for your ZIM).

benoit74 avatar Apr 30 '24 10:04 benoit74

@kelson42 could you confirm you have the same positive result with proper link in my previous comment?

benoit74 avatar Apr 30 '24 10:04 benoit74

https://library.kiwix.org/viewer#openmusictheory.com_2024-06/openmusictheory.github.io/contents.html

This is the final file in the library. @kelson42 could you please confirm so we can move forward in this issue?

RavanJAltaie avatar Jun 20 '24 19:06 RavanJAltaie

This not working https://library.kiwix.org/viewer#openmusictheory.com_2024-06/openmusictheory.github.io/cantusFirmus.html image

image image

image image

Rexadev avatar Aug 13 '24 06:08 Rexadev

Should we remove the file from prod library?

benoit74 avatar Aug 13 '24 07:08 benoit74

Is this because videos have been removed or because they're on Vimeo? Depends on the extent of the issues with the ZIM. In the past it has worked well.

Jaifroid avatar Aug 13 '24 07:08 Jaifroid

Except for the videos all the rest is there. Not an expert (nor a musician) but it looks very much like the site can serve its purpose (minus a couple examples, but again I don't know how essential these are to learning)

Popolechien avatar Aug 13 '24 07:08 Popolechien

@Popolechien In the current state the site is perfect for it's use but it would be easier if SheetMusic worked and it would look nice is dead vimeo video didn't look like a glitch and Spotify shortcut has a scroolbar.

Rexadev avatar Aug 13 '24 08:08 Rexadev

@Popolechien as we didn't get an answer to @benoit74 question. Should we delete the file from prod library?

RavanJAltaie avatar Sep 19 '24 12:09 RavanJAltaie

Looks like the site is far from perfect but can still serve its intended purpose according to @rexadev. We need clearer rules as to what kind of quality is acceptable.

Popolechien avatar Sep 19 '24 13:09 Popolechien

We need clearer rules as to what kind of quality is acceptable.

It should be on pre site basis like no external link would be a dealbreak in some website but in this it's fine

Rexadev avatar Sep 19 '24 17:09 Rexadev

I've tested the September version (https://library.kiwix.org/content/openmusictheory.com_2024-09/openmusictheory.github.io/) in Kiwix Serve and in the PWA, and in both the exercises are not working for example in Composition, Improvisation, Harmony and Rhythm. And the videos of course. There is a lot of information that is still useful though.... It seems a borderline case to me. Why not leave it in production and see if anyone complains?!

It seems increasingly urgent to me to fix at least Vimeo video. There are some brute-force methods to do it...

Regarding the in-page examples here, I suppose a custom action needs to be developed to ensure the "play" button in each example is actually pressed in Browsertrix Crawler, or else none of the assets are available for replay...

Jaifroid avatar Sep 19 '24 17:09 Jaifroid