youtube icon indicating copy to clipboard operation
youtube copied to clipboard

Fullscreen is broken in Safari

Open rgaudin opened this issue 6 years ago • 17 comments

In iOS and macOS, using Safari (via kiwix-serve), video in fullscreen is not scaled-up (but appears inside a black frame).

rgaudin avatar Sep 16 '19 17:09 rgaudin

This issue has been automatically marked as stale because it has not had recent activity. It will be now be reviewed manually. Thank you for your contributions.

stale[bot] avatar Nov 27 '19 05:11 stale[bot]

@rgaudin Do we have an upstream bug for that one?

kelson42 avatar Nov 27 '19 05:11 kelson42

This issue has been automatically marked as stale because it has not had recent activity. It will be now be reviewed manually. Thank you for your contributions.

stale[bot] avatar Jan 26 '20 05:01 stale[bot]

FYI still valid on Safari Version 13.1 (15609.1.20.111.8)

rgaudin avatar Apr 22 '20 14:04 rgaudin

This issue has been automatically marked as stale because it has not had recent activity. It will be now be reviewed manually. Thank you for your contributions.

stale[bot] avatar Jun 27 '20 16:06 stale[bot]

I would still like to see a link to the upstream bug here.

kelson42 avatar Sep 19 '20 10:09 kelson42

@rgaudin I have just tried again with Safari on ipadOS 15.1 and http://library.kiwix.org/ted_en_playlist-how-perfectionism-fails-us_2021-12/A/how-to-get-better-at-the-things-you-care-about?lang=undefined and it seems to work perfectly now. Works well as well in iphone with ios 15.1. Would you be able to conform please?

kelson42 avatar Dec 12 '21 07:12 kelson42

This ZIM has not been made with this scraper. Tested with cestpassorcier and I still have the bug.

rgaudin avatar Dec 13 '21 08:12 rgaudin

Ok, at least we know how to fix the problem... sorry if you have already answered to that questionning, but I still wonder that all this video handling is not shared code in scraperlib. Hopefully this is only a matter of time.

kelson42 avatar Dec 13 '21 08:12 kelson42

Didn't meant to confirm it works. It doesn't on macOS Safari. On iOS 15.1 iPhone, fullscreen seems to work but the video doesn't play so it's hard to be definitive.

We use a similar stack in youtube and ted but no it's not shared.

rgaudin avatar Dec 13 '21 08:12 rgaudin

This issue has been automatically marked as stale because it has not had recent activity. It will be now be reviewed manually. Thank you for your contributions.

stale[bot] avatar Mar 02 '22 10:03 stale[bot]

Upstream ticket https://github.com/brion/ogv.js/issues/228

rgaudin avatar Nov 07 '22 15:11 rgaudin

This issue has been automatically marked as stale because it has not had recent activity. It will be now be reviewed manually. Thank you for your contributions.

stale[bot] avatar May 26 '23 16:05 stale[bot]

I just tested on Mac OS 12.7 and Safari Version 17.0 (17616.1.27.111.22, 17616), and fullscreen is working well for https://library.kiwix.org/viewer#cest-pas-sorcier_fr_all_2023-03/home.html

But there is no sound ... (I opened a separate ticket https://github.com/openzim/youtube/issues/181)

Could someone test on iOS and different Mac OS versions ?

benoit74 avatar Oct 13 '23 07:10 benoit74

Idem on macOS14, same Safari version

rgaudin avatar Oct 13 '23 08:10 rgaudin

On iPadOS 16.7 fullscreen broken but sounds works.

kelson42 avatar Oct 13 '23 09:10 kelson42

I ran another test and this time sounds is working but no video is displayed at all in Safari, no mater fullscreen or not.

benoit74 avatar Oct 13 '23 12:10 benoit74

Pretty sure this would be fixed by just using latest scraperlib (like on TED). See #175

kelson42 avatar May 18 '24 13:05 kelson42

Fixed by https://github.com/openzim/youtube/pull/202

benoit74 avatar May 22 '24 07:05 benoit74