youtube icon indicating copy to clipboard operation
youtube copied to clipboard

Revisit support of Picture-in-Picture

Open benoit74 opened this issue 1 year ago • 3 comments

In 2020, https://github.com/openzim/youtube/pull/92 concluded that picture-in-picture button of video.js had to be hidden due to bad support in multiple readers / browsers.

4 years later, it is probably now time to check again if the issues we faced at that time are still present. Picture-in-picture was quite young at that time, it might have evolved significantly since then.

We need to create a small ZIM with only one video served with a video.js player with PIP button enabled. This ZIM does not need to be created with Youtube scraper at all. And then we need to test this ZIM on our readers to confirm if the landscape has changed or not.

benoit74 avatar Jun 18 '24 11:06 benoit74

I'm only familiar with PiP in iOS. On iOS, from Kiwix 3.4.0, it already works perfectly using standarts OS workflows/gestures. Therefore, I'm not sure anything else (a button) is needed. But ready to test one if needed.

kelson42 avatar Jun 18 '24 11:06 kelson42

@benoit74 Could we have an example ZIM to test?

kelson42 avatar Aug 03 '24 13:08 kelson42

Sure: https://tmp.kiwix.org/ci/tests_eng_yt-picture-in-picture_2024-08.zim

What I've seen:

  • button is never displayed on Firefox because Firefox already adds its own button (based on user preferences) ; it is a video.js feature
  • button is working well on latest Chrome on MacOS Sonoma and Android 13
  • button is grayed out on kiwix-android 3.11.1 and Android 13
  • button is displayed but not working at all on kiwix-apple 3.5.0 (167) on MacOS Sonoma
  • button behavior on PWA and Kiwix-JS is linked to the browser used (see Firefox and Chrome remarks above)
  • button is also grayed out on old Chrome of Orange tablet 2

benoit74 avatar Aug 12 '24 07:08 benoit74

Still not working on kiwix-apple, still not really needed because anyway most browsers / readers adds their own button. Closing this as "won't do".

benoit74 avatar Nov 04 '24 21:11 benoit74