youtube icon indicating copy to clipboard operation
youtube copied to clipboard

Scraper to import logo and banner from the channel/playlist

Open RavanJAltaie opened this issue 1 year ago • 5 comments

Hello, I have an enhancement suggestion that will save time and enhance youtube files quality. Can we update the Youtube scraper in a way that it scrapes the logo of the channel and the banner automatically from the channel ID while scraping the content?

RavanJAltaie avatar Apr 23 '24 22:04 RavanJAltaie

It's already the case for channels and playlists have no such thing AFAIK

rgaudin avatar Apr 24 '24 06:04 rgaudin

Closing ; reopen if I'm missing anything

rgaudin avatar Apr 24 '24 09:04 rgaudin

Can't we apply the same thing on playlists? The playlists are coming from a channel, so adding the channel logo and banner would be very useful.

RavanJAltaie avatar Apr 24 '24 21:04 RavanJAltaie

This issue is not actionable. You need to explain what you would like, and why.

You mention saving time so you can only be talking about ZIM Illustration. Those are already fetched by the scraper. It's from the channel/user or the first playlist's channel.

If you are not only talking about ZIM illustration then describe what you get and what you expect.

rgaudin avatar Apr 25 '24 10:04 rgaudin

@RavanJAltaie could you explain what you don't get and would like to get with current scraper? Is this just a lack of documentation?

benoit74 avatar Apr 30 '24 12:04 benoit74

@RavanJAltaie should we discuss it live or may I close the issue? We need more details to help you on this

benoit74 avatar May 17 '24 13:05 benoit74

@benoit74 @rgaudin the scraper is taking the logo and banner if it's a channel. If it's a playlist, it doesn't. Resulting in a file with no logo and banner, and then we need to enter them manually after checking for files with no logos.

RavanJAltaie avatar May 20 '24 00:05 RavanJAltaie

I just checked the code, and I confirm that if it's a playlist (or a list of playlist), scraper is supposed to use the logo and banner of the channel of the playlist (or first playlist in the list if we have multiple playlists).

So this is not a feature request, but a bug report.

I checked one random recipe using a playlist as ID (https://farm.openzim.org/recipes/avanti-alkyhalide/config) and the ZIM has both a logo and a banner (https://library.kiwix.org/viewer#avanti-alkyhalide_2024-03/home.html).

image

@RavanJAltaie please provide more information on where this is not working so we can help you debug this issue

benoit74 avatar May 20 '24 05:05 benoit74

Nota: the banner is a custom file provided in recipe configuration, I forgot to check that, sorry, but the logo/profile is not specified so it is fetched from online.

benoit74 avatar May 20 '24 06:05 benoit74

Clearing milestone until what's needed is clear

benoit74 avatar Jun 15 '24 12:06 benoit74

Discussed live, the bug is not there anymore. Closing until a repro arrives

benoit74 avatar Jul 23 '24 13:07 benoit74