wp1 icon indicating copy to clipboard operation
wp1 copied to clipboard

Unable to download zim

Open mou7664 opened this issue 9 months ago • 8 comments

Image Clicking on any download link

mou7664 avatar Mar 26 '25 20:03 mou7664

This is because the ZIM has expired. There should be a little red (i) next to "download ZIM" that tells you "This ZIM file has expired (2 weeks)". As the message says, the ZIM expires after 2 weeks.

audiodude avatar Mar 29 '25 03:03 audiodude

Unfortunately, there was not any option to recreate the zim or a red (i) until 2 days later

mou7664 avatar Mar 29 '25 22:03 mou7664

From my point of view we should have a proper error. Considering we use a redirect to Wasabi, this hould be easily doable.

In addition, the file should be easy to recreate, I wonder why it's not.

kelson42 avatar Mar 30 '25 06:03 kelson42

From my point of view we should have a proper error. Considering we use a redirect to Wasabi, this hould be easily doable.

We just respond with a 302 to the wasabi URL. If we'd like to detect this situation and show a more helpful error message, we would have to do a fetch with the requests library first and check for a 404.

In addition, the file should be easy to recreate, I wonder why it's not.

We don't automatically re-create ZIMs. This was a decision made long ago. When a ZIM expires, we let the user know and require them to recreate the ZIM themselves.

audiodude avatar Mar 30 '25 16:03 audiodude

From my point of view we should have a proper error. Considering we use a redirect to Wasabi, this hould be easily doable.

We just respond with a 302 to the wasabi URL. If we'd like to detect this situation and show a more helpful error message, we would have to do a fetch with the requests library first and check for a 404.

Yes, displaying a proper message about expiration and a simple invitation - with a button - to recreate straight the ZIM file.

In addition, the file should be easy to recreate, I wonder why it's not.

We don't automatically re-create ZIMs. This was a decision made long ago. When a ZIM expires, we let the user know and require them to recreate the ZIM themselves.

I think this is still correct.

kelson42 avatar Apr 04 '25 04:04 kelson42

The zim was recreated, but the download button was still there ever after expiry.

mou7664 avatar Apr 05 '25 14:04 mou7664

@mou7665 That's a good point, we shouldn't display the download link if we suspect the ZIM is expired.

audiodude avatar Apr 05 '25 14:04 audiodude

I had this same issue 3 days ago, where the selection still had the download link even after expiry.

mou7664 avatar Apr 12 '25 17:04 mou7664