wikihow icon indicating copy to clipboard operation
wikihow copied to clipboard

Setup CI

Open kelson42 opened this issue 4 years ago • 2 comments

  • code factor
  • Minimal automated testing
  • Minimal code coverage

kelson42 avatar Aug 17 '21 05:08 kelson42

* code factor

AFAIK, there's not much we can do on CI with codefactor. codefactor is subscribed to events on our repo and updates its platform on every commit and PRs (and interacts with PRs of course). It's not actionable in a way we'd expect there.

* Minimal automated testing

We can initiate a small run of the scraper, as we do in sotoki. Will require a dedicated option as no languages is small enough for this task I believe.

* Minimal code coverage

I'd advise against that. We won't have unit tests. If we run that test scrape in a test, it will cover a decent portion of the scraper, thus reporting a relatively high coverage score while none of this code will actually be tested independently. We'd only test the output zim file.

rgaudin avatar Aug 17 '21 08:08 rgaudin

This issue has been automatically marked as stale because it has not had recent activity. It will be now be reviewed manually. Thank you for your contributions.

stale[bot] avatar Mar 02 '22 13:03 stale[bot]