python-libzim icon indicating copy to clipboard operation
python-libzim copied to clipboard

remove metadata conversion

Open aryanA101a opened this issue 1 year ago • 6 comments

Fixes #188

aryanA101a avatar Feb 19 '24 06:02 aryanA101a

@rgaudin Sorry, my bad. Actually, I ran the tests after the modification but didn't install the project.

aryanA101a avatar Feb 19 '24 10:02 aryanA101a

@aryanA101a Any update?

kelson42 avatar Mar 31 '24 20:03 kelson42

converted to draft to prevent accidental merge

rgaudin avatar Apr 02 '24 12:04 rgaudin

I don't think this is sufficient: type hints should be simplified as well to explicitly mention these methods support only bytes and str values now (i.e. conversion must be done by python-scraperlib or any other "user")

benoit74 avatar Apr 04 '24 07:04 benoit74

Thank you @benoit74 ; that's right and I forgot @aryanA101a to mention that you should not force-push after having asked for a review ; it makes (and made in that case) reviewing a real pain.

rgaudin avatar Apr 04 '24 07:04 rgaudin

@aryanA101a please update type hints as suggested

rgaudin avatar Apr 04 '24 07:04 rgaudin