mwoffliner icon indicating copy to clipboard operation
mwoffliner copied to clipboard

WikimediaDesktop default CSS should be enhanced / updated

Open benoit74 opened this issue 10 months ago • 4 comments

Main visible issue is that CSS rule:

.content h2 {
  clear: both
}

This causes lots of weird layouts like below

Currently in ZIM Without the CSS rule above in ZIM Online
Image Image Image

This comes from res/inserted_style.css

@kelson42 How are we supposed to maintain this minified file? May I at least remove this CSS rule?

To me this is kinda a blocker to use WikimediaDesktop at large, since there might be other outdated / wrong rules there, we need to sort this out.

benoit74 avatar Feb 27 '25 10:02 benoit74

@benoit74 I'm abroad, therefore only a short answer. We have for sure one or two other issues dedicated to this static CSS file. Agree with you: current approach is more than problematic. I can not tell if we can remove it.

kelson42 avatar Feb 27 '25 10:02 kelson42

Postponing to later, with 2.0.0 we will use ActionParse which does not suffer from this problem.

benoit74 avatar Apr 03 '25 14:04 benoit74

LOL, we were worrying about this back in 2017... see #96.

Jaifroid avatar Apr 10 '25 16:04 Jaifroid

Glad I've hopefully finally fixed the issue 🤣

benoit74 avatar Apr 10 '25 16:04 benoit74

@benoit74 I strongly suspect that this issue would benefit now (post 1.16. release) an update.

kelson42 avatar Jul 07 '25 12:07 kelson42

This is fixed since 1.15 when we use ActionParse

benoit74 avatar Jul 07 '25 13:07 benoit74