mwoffliner icon indicating copy to clipboard operation
mwoffliner copied to clipboard

Consider using the same renderer for all pages (no separate "main page" renderer)

Open audiodude opened this issue 11 months ago • 1 comments

Currently, we branch depending on whether the article isMainPage, and use either the "desktop" class of renderers (if it is), or the "mobile" class of renderers (if it is not).

I confirm this, reason is that (Wikipedia) main page used to look so ugly in mobile view... maybe this could/should be reconsidered because:

  • this software design decision is old
  • it complexifies significantly MWoffliner

Originally posted by @kelson42 in #2090

audiodude avatar Jan 04 '25 04:01 audiodude

I don't agree this complexifies significantly the codebase. Any urgency to tackle this or shall we postpone this to later release?

benoit74 avatar Apr 03 '25 15:04 benoit74

@benoit74 AFAIK, this is the case now with "ActionParse"?

kelson42 avatar Jul 05 '25 04:07 kelson42

Technically speaking, we still use two distinct renderers. But indeed when ActionParse is chosen, it is the same for both main page and other pages.

benoit74 avatar Jul 06 '25 07:07 benoit74

Closing as there nothing more we can do here. I still believe this is good technically to keep this.

kelson42 avatar Jul 06 '25 10:07 kelson42