mwoffliner icon indicating copy to clipboard operation
mwoffliner copied to clipboard

Move to libzim7

Open kelvinhammond opened this issue 2 years ago • 2 comments

node-libzim's declartions file needs to be updated for this to work as this project is using an older version of typescript and upgrading that turned out to be more than I was willing to do.

node-libzim pull request https://github.com/openzim/node-libzim/pull/88

@kelson42 There is one failing test that I've not been able to fix, do you have someone else that can take a look? I wrote the buffer to a file and it seems corrupted but the other tests pass so I wonder if its something with the node-libzim, or libzim, or just an error in the test itself.

    TypeError: Cannot read properties of undefined (reading 'mime')                                                                                                                                                                           
        at /code/mwoffliner/test/unit/webpAndRedirection.test.ts:64:48                                                                                                                                                              
        at Generator.next (<anonymous>)                                                                                                                                                                                                       
        at fulfilled (/code/mwoffliner/test/unit/webpAndRedirection.test.ts:5:58)                                                                                                                                                                                                                                                                                                                                                                                        
    ✖ passed test for png                                                                                                                                                                                                                     
    ----------------------                                                                                                                                                                                                                    
      operator: ok                                                                                                                                                                                                                            
      expected: true                                                                                                                                                                                                                          
      actual:   false                                                                                                                                                                                                                         
      at: <anonymous> (/code/mwoffliner/test/unit/webpAndRedirection.test.ts:51:7)                                                                                                                                                  
      stack: |-                                                                                                                                                                                                                               
  Error: passed test for png                                                                                                                                                                                                                  
  at Test.assert [as _assert] (/code/mwoffliner/node_modules/tape/lib/test.js:228:54)                                                                                                                                               
  at Test.bound [as _assert] (/code/mwoffliner/node_modules/tape/lib/test.js:80:32)                                                                                                                                                 
  at Test.assert (/code/mwoffliner/node_modules/tape/lib/test.js:347:10)                                                                                                                                                            
  at Test.bound [as assert] (/code/mwoffliner/node_modules/tape/lib/test.js:80:32)                                                                                                                                                  
  at /code/mwoffliner/test/unit/webpAndRedirection.test.ts:51:7                                                                                                                                                                     
  at Generator.next (<anonymous>)                                                                                      
  at fulfilled (/code/mwoffliner/test/unit/webpAndRedirection.test.ts:5:58) 

kelvinhammond avatar Dec 31 '22 18:12 kelvinhammond

@kelvinhammond Thank you very much for this PR. Super glad to see it. Not sure about the CI problem, but indeed I could have a look. The big problem is that latest node-libzim 3.0.0 is not released yet because segmentation fault.

kelson42 avatar Jan 01 '23 11:01 kelson42

This pull request has been automatically marked as stale because it has not had recent activity. It will be now be reviewed manually. Thank you for your contributions.

stale[bot] avatar May 26 '23 17:05 stale[bot]

Superseded by https://github.com/openzim/mwoffliner/pull/2194

benoit74 avatar Mar 27 '25 21:03 benoit74